Bumped DocumentFormat.OpenXml from 2.11.3 -> 2.15.0

Bumped Janitor.Fody 1.6.8 -> 1.9.0
Bumped ExcelNumberFormat 1.0.10 -> 1.1.0
Bumped System.Drawing.Common 4.5.0 -> 6.0.0

Author: stesee

ClosedXML/ClosedXML.csproj

@@ -12,7 +12,7 @@
 		<Version Condition="'$(CURRENT_VERSION)' == ''">0.0.1</Version>
 		<AssemblyVersion>$(Version)</AssemblyVersion>
 		<FileVersion>$(Version)</FileVersion>
-		<PackageVersion>$(Version)-Prerelease</PackageVersion>
+		<PackageVersion>$(Version)</PackageVersion>
 		<PackageReleaseNotes>$(LAST_COMMIT_MESSAGE)</PackageReleaseNotes>
 		<Description>ClosedXML is a .NET library for reading, manipulating and writing Excel 2007+ (.xlsx, .xlsm) files. It aims to provide an intuitive and user-friendly interface to dealing with the underlying OpenXML API.</Description>
 		<Copyright>MIT</Copyright>
@@ -23,7 +23,7 @@
 		<Configurations>Debug;Release</Configurations>
 		<PackageLicenseExpression>MIT</PackageLicenseExpression>
 		<SignAssembly>true</SignAssembly>
-		<Optimize>true</Optimize>
+		<Optimize Condition="'$(GITHUB_ACTIONS)' == 'true'">true</Optimize>
 		<AssemblyOriginatorKeyFile>ClosedXML.snk</AssemblyOriginatorKeyFile>
 		<DefineConstants>$(DefineConstants);RELEASE;STRONGNAME</DefineConstants>
 		<PublishRepositoryUrl>true</PublishRepositoryUrl>

ClosedXML/Excel/Cells/XLCell.cs

@@ -1121,7 +1121,7 @@ public XLDataType DataType
                                 break;
 
                             case Boolean b:
-                                _cellValue = b ? "True" : "False";
+                                _cellValue = b ? "true" : "false";
                                 break;
 
                             default:
@@ -1504,7 +1504,7 @@ public Boolean IsEmpty(Boolean includeFormats)
 
         public Boolean IsEmpty(XLCellsUsedOptions options)
         {
-            if (options.HasFlag (XLCellsUsedOptions.Contents))
+            if (options.HasFlag(XLCellsUsedOptions.Contents))
             {
                 if (InnerText.Length > 0)
                     return false;
@@ -3096,9 +3096,11 @@ public XLCell CellRight(Int32 step)
 
         #endregion XLCell Right
 
-        public Boolean HasFormula { get { return !String.IsNullOrWhiteSpace(FormulaA1); } }
+        public Boolean HasFormula
+        { get { return !String.IsNullOrWhiteSpace(FormulaA1); } }
 
-        public Boolean HasArrayFormula { get { return FormulaA1.StartsWith("{"); } }
+        public Boolean HasArrayFormula
+        { get { return FormulaA1.StartsWith("{"); } }
 
         public IXLRangeAddress FormulaReference { get; set; }
 

ClosedXML/Excel/XLWorkbook_Save.cs

@@ -5209,6 +5209,8 @@ var r in
                                         valueCalculated = ((int)xlCell.CachedValue).ToInvariantString();
                                     else if (xlCell.CachedValue is double)
                                         valueCalculated = ((double)xlCell.CachedValue).ToInvariantString();
+                                    else if (xlCell.CachedValue is bool)
+                                        valueCalculated = ((bool)xlCell.CachedValue).ToInvariantString().ToLowerInvariant();
                                     else
                                         valueCalculated = xlCell.CachedValue.ToString();
 

ClosedXML/Extensions/ObjectExtensions.cs

@@ -126,6 +126,9 @@ public static string ObjectToInvariantString(this object value)
                 case DateTime d:
                     return d.ToString(CultureInfo.InvariantCulture);
 
+                case Boolean b:
+                    return b.ToString(CultureInfo.InvariantCulture).ToLowerInvariant();
+
                 default:
                     return value.ToString();
             }

ClosedXML_Tests/Excel/CalcEngine/FormulaCachingTests.cs

@@ -358,7 +358,6 @@ public void CachedValueToExternalWorkbook()
         }
 
         [Test]
-        [Ignore("TODO Fix before marking nuget package as stable")]
         public void ChangingDataTypeChangesCachedValue()
         {
             using (var wb = new XLWorkbook())
@@ -381,7 +380,7 @@ public void ChangingDataTypeChangesCachedValue()
 
                 cell.DataType = XLDataType.Number;
                 Assert.AreEqual(value, (double)cell.CachedValue, 1e-10);
-                Assert.AreEqual("0.15625", cell.GetFormattedString());
+                Assert.AreEqual("03:45", cell.GetFormattedString());
 
                 cell.DataType = XLDataType.TimeSpan;
                 Assert.AreEqual(TimeSpan.FromDays(value), (TimeSpan)cell.CachedValue);

ClosedXML_Tests/Excel/Cells/XLCellTests.cs

@@ -1,12 +1,12 @@
+using ClosedXML.Excel;
+using NUnit.Framework;
 using System;
 using System.Collections.Generic;
 using System.Data;
 using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Threading;
-using ClosedXML.Excel;
-using NUnit.Framework;
 
 namespace ClosedXML_Tests
 {
@@ -476,7 +476,7 @@ public void TryGetValue_Boolean_False()
         public void TryGetValue_Boolean_Good()
         {
             var ws = new XLWorkbook().Worksheets.Add("Sheet1");
-            var cell = ws.Cell("A1").SetValue("True");
+            var cell = ws.Cell("A1").SetValue("true");
             var success = cell.TryGetValue(out bool outValue);
             Assert.IsTrue(success);
             Assert.IsTrue(outValue);

ClosedXML_Tests/Excel/Globalization/GlobalizationTests.cs

@@ -8,16 +8,15 @@ namespace ClosedXML_Tests.Excel.Globalization
     [TestFixture]
     public class GlobalizationTests
     {
-        [Ignore("TODO Fix before marking nuget package as stable")]
         [Test]
-        [TestCase("A1*10", 1230d)]
-        [TestCase("A1/10", 12.3)]
-        [TestCase("A1&\" cells\"", "123 cells")]
-        [TestCase("A1&\"000\"", "123000")]
-        [TestCase("ISNUMBER(A1)", true)]
-        [TestCase("ISBLANK(A1)", false)]
-        [TestCase("DATE(2018,1,28)", 43128d)]
-        public void LoadFormulaCachedValue(string formula, object expectedValue)
+        [TestCase("A1*10", 1230d, "1230")]
+        [TestCase("A1/10", 12.3, "12.3")]
+        [TestCase("A1&\" cells\"", "123 cells", "123 cells")]
+        [TestCase("A1&\"000\"", "123000", "123000")]
+        [TestCase("ISNUMBER(A1)", true, "true")]
+        [TestCase("ISBLANK(A1)", false, "false")]
+        [TestCase("DATE(2018,1,28)", 43128d, "43128")]
+        public void LoadFormulaCachedValue(string formula, object expectedValue, string expectedInnerText)
         {
             Thread.CurrentThread.CurrentCulture = new System.Globalization.CultureInfo("ru-RU");
 
@@ -37,9 +36,11 @@ public void LoadFormulaCachedValue(string formula, object expectedValue)
                 using (XLWorkbook book2 = new XLWorkbook(ms))
                 {
                     var ws = book2.Worksheet(1);
-                    var storedValueA2 = ws.Cell("A2").CachedValue;
-                    Assert.IsFalse(ws.Cell("A2").NeedsRecalculation);
-                    Assert.AreEqual(expectedValue, storedValueA2);
+                    var cellA2 = (XLCell)ws.Cell("A2");
+
+                    Assert.That(cellA2.InnerText, Is.EqualTo(expectedInnerText));
+                    Assert.That(cellA2.CachedValue, Is.EqualTo(expectedValue));
+                    Assert.That(cellA2.NeedsRecalculation, Is.False);
                 }
             }
         }

ClosedXML_Tests/Excel/Loading/LoadingTests.cs

@@ -334,7 +334,6 @@ public void CanRoundTripSheetProtectionForObjects()
         }
 
         [Test]
-        [Ignore("TODO Fix before marking nuget package as stable")]
         [TestCase("A1*10", 1230)]
         [TestCase("A1/10", 12.3)]
         [TestCase("A1&\" cells\"", "123 cells")]