refactor: remove standalone BadRequestException

reason: SteveException has similar extending classes/exception.
having this exception there makes more sense wrt. cohesion.

Author: goekay

src/main/java/de/rwth/idsg/steve/SteveException.java

@@ -73,4 +73,11 @@ public NotFound(String message) {
             super(message);
         }
     }
+
+    public static class BadRequest extends SteveException {
+
+        public BadRequest(String message) {
+            super(message);
+        }
+    }
 }

src/main/java/de/rwth/idsg/steve/web/api/ApiControllerAdvice.java

@@ -20,7 +20,6 @@
 
 import de.rwth.idsg.steve.SteveException;
 import de.rwth.idsg.steve.web.DateTimeEditor;
-import de.rwth.idsg.steve.web.api.exception.BadRequestException;
 import lombok.Data;
 import lombok.extern.slf4j.Slf4j;
 import org.joda.time.DateTime;
@@ -74,9 +73,9 @@ public ApiErrorResponse handleAlreadyExistsException(HttpServletRequest req, Ste
         return createResponse(url, HttpStatus.UNPROCESSABLE_ENTITY, exception.getMessage());
     }
 
-    @ExceptionHandler(BadRequestException.class)
+    @ExceptionHandler(SteveException.BadRequest.class)
     @ResponseStatus(value = HttpStatus.BAD_REQUEST)
-    public ApiErrorResponse handleBadRequestException(HttpServletRequest req, BadRequestException exception) {
+    public ApiErrorResponse handleBadRequestException(HttpServletRequest req, SteveException.BadRequest exception) {
         String url = req.getRequestURL().toString();
         log.error("Request: {} raised following exception.", url, exception);
         return createResponse(url, HttpStatus.BAD_REQUEST, exception.getMessage());

src/main/java/de/rwth/idsg/steve/web/api/TransactionsRestController.java

@@ -18,10 +18,10 @@
  */
 package de.rwth.idsg.steve.web.api;
 
+import de.rwth.idsg.steve.SteveException;
 import de.rwth.idsg.steve.repository.TransactionRepository;
 import de.rwth.idsg.steve.repository.dto.Transaction;
 import de.rwth.idsg.steve.web.api.ApiControllerAdvice.ApiErrorResponse;
-import de.rwth.idsg.steve.web.api.exception.BadRequestException;
 import de.rwth.idsg.steve.web.dto.TransactionQueryForm;
 import io.swagger.v3.oas.annotations.Operation;
 import io.swagger.v3.oas.annotations.media.Content;
@@ -75,7 +75,7 @@ public List<Transaction> get(@Valid @ParameterObject TransactionQueryForm.Transa
         log.debug("Read request for query: {}", params);
 
         if (params.isReturnCSV()) {
-            throw new BadRequestException("returnCSV=true is not supported for API calls");
+            throw new SteveException.BadRequest("returnCSV=true is not supported for API calls");
         }
 
         var response = transactionRepository.getTransactions(params);