refactor/improvements from juherr#120

applied some of the relevant suggestions by AI review

Author: goekay

src/main/java/de/rwth/idsg/steve/SteveApplication.java

@@ -27,7 +27,9 @@
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
 import org.springframework.boot.autoconfigure.jooq.JooqAutoConfiguration;
+import org.springframework.boot.context.event.ApplicationStartedEvent;
 import org.springframework.context.ConfigurableApplicationContext;
+import org.springframework.context.event.EventListener;
 
 import java.util.TimeZone;
 
@@ -48,6 +50,10 @@ public class SteveApplication {
 
         TimeZone.setDefault(TimeZone.getTimeZone(SteveProperties.TIME_ZONE_ID));
         DateTimeZone.setDefault(DateTimeZone.forID(SteveProperties.TIME_ZONE_ID));
+    }
+
+    @EventListener(ApplicationStartedEvent.class)
+    public void logStartup() {
         log.info("Date/time zone of the application is set to {}. Current date/time: {}", SteveProperties.TIME_ZONE_ID, DateTime.now());
     }
 

src/main/java/de/rwth/idsg/steve/ocpp/soap/ClientProvider.java

@@ -75,6 +75,10 @@ private static JaxWsProxyFactoryBean getBean(String endpointAddress) {
     }
 
     private static TLSClientParameters create(Ssl ssl) throws Exception {
+        if (ssl == null || !ssl.isEnabled()) {
+            return null;
+        }
+
         String keyStorePath = ssl.getKeyStore();
         String keyStorePwd = ssl.getKeyStorePassword();
 

src/main/java/de/rwth/idsg/steve/ocpp/soap/MediatorInInterceptor.java

@@ -87,7 +87,9 @@ public final void handleMessage(SoapMessage message) {
         Server targetServer = actualServers.get(schemaNamespace);
 
         // Redirect the request
-        if (targetServer != null) {
+        if (targetServer == null) {
+            log.warn("No server mapped for namespace '{}'", schemaNamespace);
+        } else {
             targetServer.getDestination().getMessageObserver().onMessage(message);
         }
 

src/main/java/de/rwth/idsg/steve/ocpp/ws/OcppWebSocketHandshakeHandler.java

@@ -117,9 +117,9 @@ public boolean doHandshake(ServerHttpRequest request, ServerHttpResponse respons
     }
 
     private AbstractWebSocketEndpoint selectEndpoint(List<String> requestedProtocols ) {
-        for (String requestedProcotol : requestedProtocols) {
+        for (String requestedProtocol : requestedProtocols) {
             for (AbstractWebSocketEndpoint item : endpoints) {
-                if (item.getVersion().getValue().equals(requestedProcotol)) {
+                if (item.getVersion().getValue().equals(requestedProtocol)) {
                     return item;
                 }
             }

src/main/java/de/rwth/idsg/steve/service/WebUserService.java

@@ -87,7 +87,7 @@ public void afterStart(ContextRefreshedEvent event) {
 
         var headerVal = steveProperties.getAuth().getWebApiSecret();
 
-        var encodedApiPassword = StringUtils.isEmpty(headerVal)
+        var encodedApiPassword = StringUtils.isBlank(headerVal)
             ? null
             : passwordEncoder.encode(headerVal);
 

src/main/java/de/rwth/idsg/steve/utils/LogFileRetriever.java

@@ -93,7 +93,7 @@ private List<Path> getActiveLogFilePaths() {
         Iterator<Appender<ILoggingEvent>> appenderIterator = logger.iteratorForAppenders();
 
         List<Path> fileNameList = new ArrayList<>();
-        if (appenderIterator.hasNext()) {
+        while (appenderIterator.hasNext()) {
             var appender = appenderIterator.next();
             String fileName = extractFileName(appender);
             if (fileName != null) {

src/main/java/de/rwth/idsg/steve/web/validation/ChargeBoxIdListValidator.java

@@ -20,6 +20,7 @@
 
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Component;
+import org.springframework.util.CollectionUtils;
 
 import jakarta.validation.ConstraintValidator;
 import jakarta.validation.ConstraintValidatorContext;
@@ -43,6 +44,9 @@ public void initialize(ChargeBoxId constraintAnnotation) {
 
     @Override
     public boolean isValid(List<String> value, ConstraintValidatorContext context) {
+        if (CollectionUtils.isEmpty(value)) {
+            return true; // null or empty is valid, because it is another constraint's responsibility
+        }
         for (String s : value) {
             if (!validator.isValid(s, context)) {
                 return false;

src/test/java/de/rwth/idsg/steve/StressTest.java

@@ -84,7 +84,7 @@ protected void attack() throws Exception {
         } finally {
             try {
                 if (app != null) {
-                    app.stop();
+                    app.close();
                 }
             } finally {
                 if (databasePreparer != null) {