refactor

Author: goekay

src/main/java/de/rwth/idsg/steve/config/SecurityConfiguration.java

@@ -76,15 +76,9 @@ public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Excepti
             // all access, there is a global default behaviour from spring security: enable CSRF for all POSTs.
             // we need to disable CSRF for SOAP paths explicitly.
             .csrf(c -> c.ignoringRequestMatchers(CONFIG.getCxfMapping() + "/**"))
-            .sessionManagement(
-                req -> req.invalidSessionUrl(prefix + "/signin")
-            )
-            .formLogin(
-                req -> req.loginPage(prefix + "/signin").permitAll()
-            )
-            .logout(
-                req -> req.logoutUrl(prefix + "/signout")
-            )
+            .sessionManagement(req -> req.invalidSessionUrl(prefix + "/signin"))
+            .formLogin(req -> req.loginPage(prefix + "/signin").permitAll())
+            .logout(req -> req.logoutUrl(prefix + "/signout"))
             .build();
     }
 

src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java

@@ -42,11 +42,11 @@
 import org.springframework.web.bind.annotation.PutMapping;
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
-import org.springframework.web.bind.annotation.ResponseBody;
 import org.springframework.web.bind.annotation.ResponseStatus;
 import org.springframework.web.bind.annotation.RestController;
 
 import jakarta.validation.Valid;
+
 import java.util.List;
 
 /**
@@ -80,7 +80,6 @@ public class OcppTagsRestController {
         @ApiResponse(responseCode = "500", description = "Internal Server Error", content = {@Content(mediaType = "application/json", schema = @Schema(implementation = ApiErrorResponse.class))})}
     )
     @GetMapping(value = "")
-    @ResponseBody
     public List<OcppTagOverview> get(@ParameterObject OcppTagQueryFormForApi params) {
         log.debug("Read request for query: {}", params);
 
@@ -100,7 +99,6 @@ public List<OcppTagOverview> get(@ParameterObject OcppTagQueryFormForApi params)
         @ApiResponse(responseCode = "500", description = "Internal Server Error", content = {@Content(mediaType = "application/json", schema = @Schema(implementation = ApiErrorResponse.class))})}
     )
     @GetMapping("/{ocppTagPk}")
-    @ResponseBody
     public OcppTagOverview getOne(@PathVariable("ocppTagPk") Integer ocppTagPk) {
         log.debug("Read request for ocppTagPk: {}", ocppTagPk);
 
@@ -122,7 +120,6 @@ public OcppTagOverview getOne(@PathVariable("ocppTagPk") Integer ocppTagPk) {
         @ApiResponse(responseCode = "500", description = "Internal Server Error", content = {@Content(mediaType = "application/json", schema = @Schema(implementation = ApiErrorResponse.class))})}
     )
     @PostMapping
-    @ResponseBody
     @ResponseStatus(HttpStatus.CREATED)
     public OcppTagOverview create(@RequestBody @Valid OcppTagForm params) {
         log.debug("Create request: {}", params);
@@ -145,7 +142,6 @@ public OcppTagOverview create(@RequestBody @Valid OcppTagForm params) {
         @ApiResponse(responseCode = "500", description = "Internal Server Error", content = {@Content(mediaType = "application/json", schema = @Schema(implementation = ApiErrorResponse.class))})}
     )
     @PutMapping("/{ocppTagPk}")
-    @ResponseBody
     public OcppTagOverview update(@PathVariable("ocppTagPk") Integer ocppTagPk, @RequestBody @Valid OcppTagForm params) {
         params.setOcppTagPk(ocppTagPk); // the one from incoming params does not matter
         log.debug("Update request: {}", params);
@@ -169,7 +165,6 @@ public OcppTagOverview update(@PathVariable("ocppTagPk") Integer ocppTagPk, @Req
         @ApiResponse(responseCode = "500", description = "Internal Server Error", content = {@Content(mediaType = "application/json", schema = @Schema(implementation = ApiErrorResponse.class))})}
     )
     @DeleteMapping("/{ocppTagPk}")
-    @ResponseBody
     public OcppTagOverview delete(@PathVariable("ocppTagPk") Integer ocppTagPk) {
         log.debug("Delete request for ocppTagPk: {}", ocppTagPk);
 

src/main/java/de/rwth/idsg/steve/web/api/TransactionsRestController.java

@@ -35,10 +35,10 @@
 import org.springframework.http.MediaType;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.RequestMapping;
-import org.springframework.web.bind.annotation.ResponseBody;
 import org.springframework.web.bind.annotation.RestController;
 
 import jakarta.validation.Valid;
+
 import java.util.List;
 
 /**
@@ -70,7 +70,6 @@ public class TransactionsRestController {
         @ApiResponse(responseCode = "500", description = "Internal Server Error", content = {@Content(mediaType = "application/json", schema = @Schema(implementation = ApiErrorResponse.class))})}
     )
     @GetMapping(value = "")
-    @ResponseBody
     public List<Transaction> get(@Valid @ParameterObject TransactionQueryForm.TransactionQueryFormForApi params) {
         log.debug("Read request for query: {}", params);