switch to Controller-based redirect for root to /manager

Author: goekay

src/main/java/de/rwth/idsg/steve/JettyServer.java

@@ -99,7 +99,7 @@ private void prepare() {
         }
 
         steveAppContext = new SteveAppContext();
-        server.setHandler(steveAppContext.getHandlers());
+        server.setHandler(steveAppContext.getHandler());
     }
 
     private ServerConnector httpConnector(HttpConfiguration httpConfig) {

src/main/java/de/rwth/idsg/steve/SteveAppContext.java

@@ -19,16 +19,11 @@
 package de.rwth.idsg.steve;
 
 import org.eclipse.jetty.ee10.webapp.WebAppContext;
-import org.eclipse.jetty.rewrite.handler.RedirectPatternRule;
-import org.eclipse.jetty.rewrite.handler.RewriteHandler;
 import org.eclipse.jetty.server.Handler;
-import org.eclipse.jetty.server.handler.ContextHandler;
-import org.eclipse.jetty.server.handler.ContextHandlerCollection;
 import org.eclipse.jetty.server.handler.gzip.GzipHandler;
 import org.springframework.core.io.ClassPathResource;
 
 import java.io.IOException;
-import java.util.HashSet;
 
 import static de.rwth.idsg.steve.SteveConfiguration.CONFIG;
 
@@ -65,11 +60,8 @@ public SteveAppContext() {
         webAppContext.setAttribute("org.eclipse.jetty.server.webapp.ContainerIncludeJarPattern", SCAN_PATTERN);
     }
 
-    public ContextHandlerCollection getHandlers() {
-        return new ContextHandlerCollection(
-            new ContextHandler(getRedirectHandler()),
-            new ContextHandler(getWebApp())
-        );
+    public Handler getHandler() {
+        return getWebApp();
     }
 
     private Handler getWebApp() {
@@ -82,34 +74,6 @@ private Handler getWebApp() {
         return new GzipHandler(webAppContext);
     }
 
-    private Handler getRedirectHandler() {
-        RewriteHandler rewrite = new RewriteHandler();
-        for (String redirect : getRedirectSet()) {
-            RedirectPatternRule rule = new RedirectPatternRule();
-            rule.setTerminating(true);
-            rule.setPattern(redirect);
-            rule.setLocation(CONFIG.getContextPath() + "/manager/home");
-            rewrite.addRule(rule);
-        }
-        return rewrite;
-    }
-
-    private HashSet<String> getRedirectSet() {
-        String path = CONFIG.getContextPath();
-
-        HashSet<String> redirectSet = new HashSet<>(3);
-        redirectSet.add("");
-        redirectSet.add(path + "");
-
-        // Otherwise (if path = ""), we would already be at root of the server ("/")
-        // and using the redirection below would cause an infinite loop.
-        if (!"".equals(path)) {
-            redirectSet.add(path + "/");
-        }
-
-        return redirectSet;
-    }
-
     private static String getWebAppURIAsString() {
         try {
             return new ClassPathResource("webapp").getURI().toString();

src/main/java/de/rwth/idsg/steve/config/ApiDocsConfiguration.java

@@ -31,10 +31,12 @@
 import org.springdoc.core.properties.SwaggerUiOAuthProperties;
 import org.springdoc.webmvc.core.configuration.SpringDocWebMvcConfiguration;
 import org.springdoc.webmvc.ui.SwaggerConfig;
+import org.springdoc.webmvc.ui.SwaggerUiHome;
 import org.springframework.boot.autoconfigure.jackson.JacksonAutoConfiguration;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.Configuration;
+import org.springframework.context.annotation.FilterType;
 import org.springframework.context.annotation.Import;
 
 import java.util.List;
@@ -46,7 +48,10 @@
  * @since 15.09.2022
  */
 @Configuration
-@ComponentScan(basePackages = {"org.springdoc"})
+@ComponentScan(basePackages = {"org.springdoc"},
+    // exclude because SwaggerUiHome's root redirect clashes with our own RootRedirectController
+    excludeFilters = @ComponentScan.Filter(type = FilterType.ASSIGNABLE_TYPE, classes = SwaggerUiHome.class)
+)
 @Import({SpringDocConfiguration.class,
     SpringDocWebMvcConfiguration.class,
     SwaggerConfig.class,

src/main/java/de/rwth/idsg/steve/config/SecurityConfiguration.java

@@ -64,6 +64,7 @@ public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Excepti
             .authorizeHttpRequests(
                 req -> req
                     .requestMatchers(
+                        "/", // we have RootRedirectController to redirect "/" to "/manager"
                         "/static/**",
                         CONFIG.getCxfMapping() + "/**",
                         WebSocketConfiguration.PATH_INFIX + "**",

src/main/java/de/rwth/idsg/steve/web/controller/RootRedirectController.java

@@ -0,0 +1,37 @@
+/*
+ * SteVe - SteckdosenVerwaltung - https://github.com/steve-community/steve
+ * Copyright (C) 2013-2025 SteVe Community Team
+ * All Rights Reserved.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+package de.rwth.idsg.steve.web.controller;
+
+import org.springframework.stereotype.Controller;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+
+/**
+ * @author Sevket Goekay <[email protected]>
+ * @since 17.09.2025
+ */
+@Controller
+@RequestMapping("/")
+public class RootRedirectController {
+
+    @GetMapping
+    public String redirectToManager() {
+        return "redirect:/manager";
+    }
+}