Skip to content

Commit f861092

Browse files
authored
Merge pull request #1534 from steve-community/fix_api_error_msg
fix ObjectMapper used for API endpoint errors
2 parents fe40cd6 + 678c245 commit f861092

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import com.fasterxml.jackson.databind.DeserializationFeature;
2222
import com.fasterxml.jackson.databind.ObjectMapper;
2323
import com.fasterxml.jackson.databind.SerializationFeature;
24-
import com.fasterxml.jackson.datatype.joda.JodaModule;
2524
import com.google.common.util.concurrent.ThreadFactoryBuilder;
2625
import com.mysql.cj.conf.PropertyKey;
2726
import com.zaxxer.hikari.HikariConfig;
@@ -266,7 +265,7 @@ public void extendMessageConverters(List<HttpMessageConverter<?>> converters) {
266265
* {@link WebMvcConfigurationSupport#requestMappingHandlerAdapter(ContentNegotiationManager, FormattingConversionService, org.springframework.validation.Validator)}.
267266
*/
268267
@Bean
269-
public ObjectMapper objectMapper(RequestMappingHandlerAdapter requestMappingHandlerAdapter) {
268+
public ObjectMapper jacksonObjectMapper(RequestMappingHandlerAdapter requestMappingHandlerAdapter) {
270269
return requestMappingHandlerAdapter.getMessageConverters().stream()
271270
.filter(converter -> converter instanceof MappingJackson2HttpMessageConverter)
272271
.findAny()

src/main/java/de/rwth/idsg/steve/config/SecurityConfiguration.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import de.rwth.idsg.steve.SteveProdCondition;
2424
import de.rwth.idsg.steve.web.api.ApiControllerAdvice;
2525
import lombok.extern.slf4j.Slf4j;
26+
import org.springframework.beans.factory.annotation.Qualifier;
2627
import org.springframework.context.annotation.Bean;
2728
import org.springframework.context.annotation.Conditional;
2829
import org.springframework.context.annotation.Configuration;
@@ -116,13 +117,13 @@ public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Excepti
116117

117118
@Bean
118119
@Order(1)
119-
public SecurityFilterChain apiKeyFilterChain(HttpSecurity http, ObjectMapper objectMapper) throws Exception {
120+
public SecurityFilterChain apiKeyFilterChain(HttpSecurity http, ObjectMapper jacksonObjectMapper) throws Exception {
120121
return http.securityMatcher(CONFIG.getApiMapping() + "/**")
121122
.csrf(k -> k.disable())
122123
.sessionManagement(k -> k.sessionCreationPolicy(SessionCreationPolicy.STATELESS))
123124
.addFilter(new ApiKeyFilter())
124125
.authorizeHttpRequests(k -> k.anyRequest().authenticated())
125-
.exceptionHandling(k -> k.authenticationEntryPoint(new ApiKeyAuthenticationEntryPoint(objectMapper)))
126+
.exceptionHandling(k -> k.authenticationEntryPoint(new ApiKeyAuthenticationEntryPoint(jacksonObjectMapper)))
126127
.build();
127128
}
128129

0 commit comments

Comments
 (0)