Skip to content

Commit d99381e

Browse files
committed
Improve naming for target library in CMakeLists.txt
1 parent 05f2788 commit d99381e

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

src/Beman/Optional26/CMakeLists.txt

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,22 @@
33
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
44
# cmake-format: on
55

6-
set(TARGET_LIBRARY "beman_optional26")
6+
add_library(beman_optional26 STATIC "")
77

8-
add_library("${TARGET_LIBRARY}" STATIC "")
9-
10-
target_sources("${TARGET_LIBRARY}" PRIVATE optional.cpp detail/iterator.cpp)
8+
target_sources(beman_optional26 PRIVATE optional.cpp detail/iterator.cpp)
119

1210
include(GNUInstallDirs)
1311
include_directories(${CMAKE_CURRENT_SOURCE_DIR})
1412

1513
target_include_directories(
16-
"${TARGET_LIBRARY}"
14+
beman_optional26
1715
PUBLIC
1816
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../../include>
1917
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}/${CMAKE_LOWER_PROJECT_NAME}> # <prefix>/include/scratch
2018
)
2119

2220
install(
23-
TARGETS "${TARGET_LIBRARY}"
21+
TARGETS beman_optional26
2422
EXPORT ${TARGETS_EXPORT_NAME}1
2523
DESTINATION ${CMAKE_INSTALL_LIBDIR})
2624

@@ -32,7 +30,7 @@ install(
3230
FILES_MATCHING
3331
PATTERN "*.hpp")
3432

35-
target_link_libraries("${TARGET_LIBRARY}")
33+
target_link_libraries(beman_optional26)
3634

3735
# Tests
3836
if(BUILD_TESTING)

src/Beman/Optional26/tests/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ add_executable(optional_test
1515
detail/iterator.t.cpp
1616
)
1717

18-
target_link_libraries(optional_test "${TARGET_LIBRARY}" GTest::gtest GTest::gtest_main)
18+
target_link_libraries(optional_test beman_optional26 GTest::gtest GTest::gtest_main)
1919

2020
# Note: clang-19 + gtest_discover_tests + Asan setup causes errors on some platforms.
2121
# Temporary switch to gtest_add_tests and skip some Asan checks.

0 commit comments

Comments
 (0)