refactor: reduce duplicated buffer soft delete logic

Author: stevearc

.github/workflows/tests.yml

@@ -4,6 +4,7 @@ on:
   push:
     branches:
       - master
+      - stevearc-*
   pull_request:
     branches:
       - master

lua/overseer/task.lua

@@ -343,7 +343,7 @@ function Task:is_disposed()
 end
 
 ---Get the buffer containing the task output. Will be nil if task is PENDING.
----@return number|nil
+---@return integer|nil
 function Task:get_bufnr()
   local bufnr = self.strategy:get_bufnr()
   if bufnr and vim.api.nvim_buf_is_valid(bufnr) then
@@ -562,13 +562,7 @@ function Task:dispose(force)
   self.strategy:dispose()
   self:dispatch("on_dispose")
   task_list.remove(self)
-  if bufnr and vim.api.nvim_buf_is_valid(bufnr) then
-    if bufnr_visible then
-      vim.bo[bufnr].bufhidden = "wipe"
-    else
-      vim.api.nvim_buf_delete(bufnr, { force = true })
-    end
-  end
+  util.soft_delete_buf(bufnr)
   return true
 end
 

lua/overseer/util.lua

@@ -688,7 +688,7 @@ M.status_to_log_level = function(status)
 end
 
 ---Delete buffer. If buffer is visible, set bufhidden=wipe instead
----@param bufnr integer
+---@param bufnr? integer
 M.soft_delete_buf = function(bufnr)
   if bufnr and vim.api.nvim_buf_is_valid(bufnr) then
     if M.is_bufnr_visible(bufnr) then