Merge pull request openstack-k8s-operators#637 from mumesan/OSPRH-18888

openshift-merge-bot[bot] · web-flow · commit 1efd0f620a3f · 2025-10-27T11:16:02.000Z
Remove TODO in validateDelete function &lt;JIRA: OSPRH-18888&gt;
diff --git a/api/v1beta1/ironic_webhook.go b/api/v1beta1/ironic_webhook.go
@@ -204,11 +204,10 @@ func (spec *IronicSpecCore) ValidateUpdate(old IronicSpecCore, basePath *field.P
 	return allErrs
 }
 
-// ValidateDelete implements webhook.Validator so a webhook will be registered for the type
+// NOTE: webhook.Validator requires this function to exist even as a no-op
 func (r *Ironic) ValidateDelete() (admission.Warnings, error) {
 	ironiclog.Info("validate delete", "name", r.Name)
 
-	// TODO(user): fill in your validation logic upon object deletion.
 	return nil, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -204,11 +204,10 @@ func (spec IronicSpecCore) ValidateUpdate(old IronicSpecCore, basePath field.P`
`204`	`204`	`return allErrs`
`205`	`205`	`}`
`206`	`206`
`207`		`-// ValidateDelete implements webhook.Validator so a webhook will be registered for the type`
	`207`	`+// NOTE: webhook.Validator requires this function to exist even as a no-op`
`208`	`208`	`func (r *Ironic) ValidateDelete() (admission.Warnings, error) {`
`209`	`209`	`ironiclog.Info("validate delete", "name", r.Name)`
`210`	`210`
`211`		`- // TODO(user): fill in your validation logic upon object deletion.`
`212`	`211`	`return nil, nil`
`213`	`212`	`}`
`214`	`213`