Set DSO true_size by _.size limits

[enzodbspace]

Hi!,

I'm working on v0.18 (great update!) I'm customizing some DSO parameters. Is this a good way to set DSO true_size based on the _.size data? My intention is to set a limit below which true_size is False, and above which it is True, to correctly represent large objects, but not make smaller ones too small (customized for each type of object)

Sample code for open clusters:

dso_open_cluster_mag_limit = 11
dso_open_cluster_size_limit = 0.01

p.open_clusters(
	where=[
		(_.magnitude <= dso_open_cluster_mag_limit) & (_.size <= dso_open_cluster_size_limit)
	],
	true_size=False,
	where_labels=[True],
	label_fn = format_dso_label
)

p.open_clusters(
	where=[
		(_.magnitude <= dso_open_cluster_mag_limit) & (_.size > dso_open_cluster_size_limit)
	],
	true_size=True,
	where_labels=[True],
	label_fn = format_dso_label
)

Can it be done in a single declaration?

Thanks!

[steveberardi]

yeah, that's probably the best way to do it currently. I have a lot of similar code with the exact same approach. I'd definitely like to improve this part of the API though, since it's such a common use-case. I'll put something on the roadmap to investigate this more. Thanks for the feedback!

[enzodbspace]

Excellent. Thank you @steveberardi for you great work! ✨