We only support Ruby 3.2 or higher and fix bug in parameters method override

Author: stevegeek

.devcontainer/devcontainer.json

@@ -7,6 +7,6 @@
   },
   "forwardPorts": [3000],
   "postCreateCommand": "bundle install && bundle exec appraisal install",
-  "postStartCommand": "bin/test",
+  "postStartCommand": "bundle exec rake test",
   "remoteUser": "vscode"
 }

Gemfile

@@ -7,7 +7,7 @@ gemspec
 gem "literal", "~> 1.0"
 
 gem "standard"
-gem "simplecov"
+gem "simplecov", require: false, group: :test
 
 gem "rails"
 gem "sqlite3"
@@ -21,7 +21,3 @@ gem "appraisal", require: false
 
 # Start debugger with binding.b [https://github.com/ruby/debug]
 # gem "debug", ">= 1.0.0"
-
-if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("3.2.0")
-  gem "polyfill-data"
-end

Rakefile

@@ -0,0 +1,14 @@
+require "bundler/setup"
+require "bundler/gem_tasks"
+
+desc "Run all tests"
+task :test do
+  sh "bin/test"
+end
+
+desc "Run Rails tests"
+task :rails_test do
+  sh "bin/rails_test"
+end
+
+task default: [:test, :rails_test]

lib/typed_operation.rb

@@ -1,7 +1,3 @@
-if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("3.2.0")
-  require "polyfill-data"
-end
-
 require "literal"
 
 require "typed_operation/version"

lib/typed_operation/action_policy_auth.rb

@@ -34,7 +34,7 @@ def authorized_via(*via, with: nil, to: nil, record: nil, &auth_block)
         raise ArgumentError, "authorize_via must be called with a valid param name" unless via.all? { |param| parameters.include?(param) }
         @_authorized_via_param = via
 
-        action_type_method = "#{action_type}?".to_sym if action_type
+        action_type_method = :"#{action_type}?" if action_type
         # If an method name is provided, use it
         policy_method = to || action_type_method || raise(::TypedOperation::InvalidOperationError, "You must provide an action type or policy method name")
         @_policy_method = policy_method

lib/typed_operation/operations/parameters.rb

@@ -5,8 +5,12 @@ module Operations
     # Method to define parameters for your operation.
     module Parameters
       # Override literal `prop` to prevent creating writers (Literal::Data does this by default)
-      def self.prop(name, type, kind = :keyword, reader: :public, writer: :public, default: nil)
-        super(name, type, kind, reader:, writer: false, default:)
+      def prop(name, type, kind = :keyword, reader: :public, writer: :public, default: nil)
+        if self < ImmutableBase
+          super(name, type, kind, reader:, default:)
+        else
+          super(name, type, kind, reader:, writer: false, default:)
+        end
       end
 
       # Parameter for keyword argument, or a positional argument if you use positional: true

test/test_helper.rb

@@ -1,3 +1,6 @@
+require "simplecov"
+SimpleCov.start
+
 if ENV["NO_RAILS"]
   puts "Running tests without Rails (ie not running the generator tests)"
 

test/typed_operation/base_test.rb

@@ -462,5 +462,17 @@ def test_can_dup
       assert_equal "2", operation2.bar
       assert_equal "3", operation2.baz
     end
+
+    def test_not_frozen
+      operation = TestOperation.new(foo: "1", bar: "2", baz: "3")
+      refute operation.frozen?
+    end
+
+    def test_cannot_write_property
+      operation = TestOperation.new(foo: "1", bar: "2", baz: "3")
+      assert_raises do
+        operation.foo = 2
+      end
+    end
   end
 end