Skip to content

Commit ebdbc71

Browse files
committed
Add more comments
1 parent d8ba2df commit ebdbc71

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

src/SqlBulkCopyMerge/Logger.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public static void Error(string message, params object[] args)
3737
}
3838
}
3939

40-
public class EmptyLogger : ILogger
40+
internal class EmptyLogger : ILogger
4141
{
4242
public void Verbose(string message, params object[] args)
4343
{

src/SqlBulkCopyMerge/SqlBulkCopyMergeService.cs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
namespace SqlBulkCopyMerge
1616
{
1717
/// <summary>
18-
/// Copy data from a table in one database to a table in another database without truncating
18+
/// Simplify common workflows that copy table data between SQL Server databases
1919
/// </summary>
2020
public interface ISqlBulkCopyMergeService
2121
{
@@ -92,7 +92,8 @@ public interface ISqlBulkCopyMergeService
9292
Task<int> CopyLatest(string sourceTable, string targetTable, CancellationToken cancellationToken, string keyColumnName = null, List<ColumnMapping> columnMappings = null, SqlBulkCopyConfig sqlBulkCopyConfig = null);
9393

9494
/// <summary>
95-
/// SQL Bulk Copy
95+
/// SQL Bulk Copy<br/>
96+
/// This method is used internally but is public as it may be suitable for other uses.
9697
/// </summary>
9798
/// <param name="sourceSelectQuery"></param>
9899
/// <param name="targetTable"></param>
@@ -106,7 +107,8 @@ Task<int> SqlBulkCopy(string sourceSelectQuery, string targetTable,
106107
SqlBulkCopyConfig sqlBulkCopyConfig = null);
107108

108109
/// <summary>
109-
/// SQL Bulk Copy
110+
/// SQL Bulk Copy<br/>
111+
/// This method is used internally but is public as it may be suitable for other uses.
110112
/// </summary>
111113
/// <param name="sourceSelectQuery"></param>
112114
/// <param name="targetTable"></param>
@@ -130,8 +132,13 @@ public class SqlBulkCopyMergeService : ISqlBulkCopyMergeService
130132
private readonly ILogger _logger;
131133

132134
/// <summary>
133-
/// Copy data from a table in one database to a table in another database without truncating
135+
/// Simplify common workflows that copy table data between SQL Server databases
134136
/// </summary>
137+
/// <param name="sourceDbConnectionString">Source database connection string.<br/>
138+
/// Requires READER permission.</param>
139+
/// <param name="targetDbConnectionString">Target database connection string.<br/>
140+
/// Requires READER + WRITER + CREATE TABLE + EXECUTE permissions.</param>
141+
/// <param name="logger">Inject an optional logger</param>
135142
public SqlBulkCopyMergeService(string sourceDbConnectionString, string targetDbConnectionString, ILogger logger = null)
136143
{
137144
_sourceDbConnectionString = sourceDbConnectionString;

0 commit comments

Comments
 (0)