bug fix: stop (sometimes) selecting wrong preview. remove redundant/bug fix: stop reopening in AltTab (red traffic light spam) (causes crash)

Author: steventheworker

src/ScriptCommands/showAppScriptCommand.swift

@@ -71,9 +71,7 @@ class showAppScriptCommand: NSScriptCommand {
             App.app.isFirstSummon = false
             App.app.shortcutIndex = 2 // Shortcut 3 = index 2 = DockAltTab
             NSScreen.updatePreferred()
-            if !Windows.updatesBeforeShowing() {
-                print("ydaaaaa")
-                App.app.hideUi(); return self } //commented out since active app = 0 windows = no previews for any tarApp, and modifying updatesBeforeShowing leads to keeping thumbnailsPanel open with 0 thumbnails (empty grey window)
+            if !Windows.updatesBeforeShowing() {App.app.hideUi(); return self }
 
 //            Windows.detectTabbedWindows()
 //            Spaces.refreshAllIdsAndIndexes()

src/logic/Window.swift

@@ -124,13 +124,6 @@ class Window {
                 closeButton_.performAction(kAXPressAction)
             }
         }
-        //DockAltTab block below (auto reopen traffic controls)
-        DispatchQueue.main.asyncAfter(deadline: .now() + 160/1000) {
-            if let hoveredWindowIndex = Windows.hoveredWindowIndex,
-               let recycledView = ThumbnailsView.recycledViews[safe: hoveredWindowIndex] {
-                recycledView.mouseMoved()
-            }
-        }
     }
 
     func canBeMinDeminOrFullscreened() -> Bool {
@@ -155,13 +148,6 @@ class Window {
                 self.axUiElement!.setAttribute(kAXMinimizedAttribute, !self.isMinimized)
             }
         }
-        //DockAltTab block below (auto reopen traffic controls)
-        DispatchQueue.main.asyncAfter(deadline: .now() + 666/1000) {
-            if let hoveredWindowIndex = Windows.hoveredWindowIndex,
-               let recycledView = ThumbnailsView.recycledViews[safe: hoveredWindowIndex] {
-                recycledView.mouseMoved()
-            }
-        }
     }
 
     func toggleFullscreen() {

src/logic/Windows.swift

@@ -103,9 +103,9 @@ class Windows {
            let lastFocusedWindowIndex = getLastFocusedWindowIndex() {
             updateFocusedAndHoveredWindowIndex(lastFocusedWindowIndex)
         } else {
-            if (DockAltTabMode && DockAltTabDockPos == "right") {
-                cycleFocusedWindowIndex(list.count - 1)
-                updateFocusedAndHoveredWindowIndex(list.count - 1)
+            if (DockAltTabMode) {
+                cycleFocusedWindowIndex(DockAltTabDockPos == "right" ? list.count - 1 : 0)
+                updateFocusedAndHoveredWindowIndex(DockAltTabDockPos == "right" ? list.count - 1 : 0)
             } else {
                 cycleFocusedWindowIndex(1)
                 if focusedWindowIndex == 0 {