updated expected fails to stay failed (ansible-collections#143)

KyeMaloy97 · GitHub Enterprise · commit 412c1fa51722 · 2024-01-17T17:24:49.000Z
Signed-off-by: Kye Maloy &lt;kye.maloy@ibm.com&gt;
diff --git a/.gitignore b/.gitignore
@@ -5,6 +5,7 @@ docs/build/
 __pycache__
 venv*
 .venv
+core
 tests/output
 ibm-ibm_zos_cics-*.tar.gz
 tests/integration/inventory
diff --git a/tests/integration/targets/cics_auxiliary_temp/playbooks/check_bad_temp_location.yml b/tests/integration/targets/cics_auxiliary_temp/playbooks/check_bad_temp_location.yml
@@ -27,7 +27,7 @@
       ibm.ibm_zos_cics.auxiliary_temp:
         state: "initial"
       register: res
-      failed_when: false
+      ignore_errors: true
 
     - name: Debug
       ansible.builtin.debug:
@@ -36,7 +36,7 @@
     - name: Assert Failure
       ansible.builtin.assert:
         that:
-          - res.failed is false
+          - res.failed is true
           - res.changed is false
           - res.rc == 1
           - "'exception' in res"
diff --git a/tests/integration/targets/cics_auxiliary_temp/playbooks/check_uppercase_location.yml b/tests/integration/targets/cics_auxiliary_temp/playbooks/check_uppercase_location.yml
@@ -44,7 +44,6 @@
       ibm.ibm_zos_cics.auxiliary_temp:
         state: "initial"
       register: result
-      failed_when: false
 
     - name: Debug
       ansible.builtin.debug:
diff --git a/tests/integration/targets/cics_global_catalog/playbooks/check_bad_gcd_location.yml b/tests/integration/targets/cics_global_catalog/playbooks/check_bad_gcd_location.yml
@@ -30,7 +30,7 @@
       ibm.ibm_zos_cics.global_catalog:
         state: "initial"
       register: res
-      failed_when: false
+      ignore_errors: true
 
     - name: Debug
       ansible.builtin.debug:
@@ -39,7 +39,7 @@
     - name: Assert Failure
       ansible.builtin.assert:
         that:
-          - res.failed is false
+          - res.failed is true
           - res.changed is false
           - res.rc == 1
           - "'exception' in res"
diff --git a/tests/integration/targets/cics_global_catalog/playbooks/check_uppercase_location.yml b/tests/integration/targets/cics_global_catalog/playbooks/check_uppercase_location.yml
@@ -46,7 +46,6 @@
       ibm.ibm_zos_cics.global_catalog:
         state: "initial"
       register: result
-      failed_when: false
 
     - name: Debug
       ansible.builtin.debug:
diff --git a/tests/integration/targets/cics_intrapartition/playbooks/check_bad_intra_location.yml b/tests/integration/targets/cics_intrapartition/playbooks/check_bad_intra_location.yml
@@ -29,7 +29,7 @@
       ibm.ibm_zos_cics.intrapartition:
         state: "initial"
       register: res
-      failed_when: false
+      ignore_errors: true
 
     - name: Debug
       ansible.builtin.debug:
@@ -38,7 +38,7 @@
     - name: Assert Failure
       ansible.builtin.assert:
         that:
-          - res.failed is false
+          - res.failed is true
           - res.changed is false
           - res.rc == 1
           - "'exception' in res"
diff --git a/tests/integration/targets/cics_intrapartition/playbooks/check_uppercase_location.yml b/tests/integration/targets/cics_intrapartition/playbooks/check_uppercase_location.yml
@@ -46,7 +46,6 @@
       ibm.ibm_zos_cics.intrapartition:
         state: "initial"
       register: result
-      failed_when: false
 
     - name: Debug
       ansible.builtin.debug:
diff --git a/tests/integration/targets/cics_local_catalog/playbooks/check_bad_lcd_location.yml b/tests/integration/targets/cics_local_catalog/playbooks/check_bad_lcd_location.yml
@@ -27,7 +27,7 @@
           dfhlcd:
             dsn: "{{ region_dataset_path }}..."
       register: res
-      failed_when: false
+      ignore_errors: true
 
     - name: Debug
       ansible.builtin.debug:
@@ -36,7 +36,7 @@
     - name: Assert Failure
       ansible.builtin.assert:
         that:
-          - res.failed is false
+          - res.failed is true
           - res.changed is false
           - res.rc == 1
           - "'exception' in res"
diff --git a/tests/integration/targets/cics_local_catalog/playbooks/check_uppercase_location.yml b/tests/integration/targets/cics_local_catalog/playbooks/check_uppercase_location.yml
@@ -44,7 +44,6 @@
         space_type: "M"
         state: "initial"
       register: result
-      failed_when: false
 
     - name: Debug
       ansible.builtin.debug:
diff --git a/tests/integration/targets/cics_local_request_queue/playbooks/check_bad_lrq_location.yml b/tests/integration/targets/cics_local_request_queue/playbooks/check_bad_lrq_location.yml
@@ -27,7 +27,7 @@
       ibm.ibm_zos_cics.local_request_queue:
         state: "initial"
       register: res
-      failed_when: false
+      ignore_errors: true
 
     - name: Debug
       ansible.builtin.debug:
@@ -36,7 +36,7 @@
     - name: Assert Failure
       ansible.builtin.assert:
         that:
-          - res.failed is false
+          - res.failed is true
           - res.changed is false
           - res.rc == 1
           - "'exception' in res"
diff --git a/tests/integration/targets/cics_local_request_queue/playbooks/check_uppercase_location.yml b/tests/integration/targets/cics_local_request_queue/playbooks/check_uppercase_location.yml
@@ -44,7 +44,6 @@
       ibm.ibm_zos_cics.local_request_queue:
         state: "initial"
       register: result
-      failed_when: false
 
     - name: Debug
       ansible.builtin.debug:
diff --git a/tests/integration/targets/cics_region_group/playbooks/data_sets.yml b/tests/integration/targets/cics_region_group/playbooks/data_sets.yml
@@ -71,13 +71,13 @@
       ibm.ibm_zos_cics.global_catalog:
         state: "initial"
       register: initial_result_glo
-      failed_when: false
+      ignore_errors: true
 
     - name: Assert Failed for python 2.7
       when: ansible_version.minor <= 11
       ansible.builtin.assert:
         that:
-          - initial_result_glo.failed is false
+          - initial_result_glo.failed is true
           - initial_result_glo.changed is false
           - initial_result_glo.msg == 'region_data_sets required'
 
@@ -101,13 +101,13 @@
       ibm.ibm_zos_cics.local_catalog:
         state: "initial"
       register: initial_result_loc
-      failed_when: false
+      ignore_errors: true
 
     - name: Assert Failed for python 2.7
       when: ansible_version.minor <= 11
       ansible.builtin.assert:
         that:
-          - initial_result_loc.failed is false
+          - initial_result_loc.failed is true
           - initial_result_loc.changed is false
           - initial_result_loc.msg == 'region_data_sets required'
 
@@ -129,7 +129,7 @@
       ibm.ibm_zos_cics.local_request_queue:
         state: "initial"
       register: initial_result_lrq
-      failed_when: false
+      ignore_errors: true
 
     - name: Debug
       ansible.builtin.debug:
@@ -139,7 +139,7 @@
       when: ansible_version.minor <= 11
       ansible.builtin.assert:
         that:
-          - initial_result_lrq.failed is false
+          - initial_result_lrq.failed is true
           - initial_result_lrq.changed is false
           - initial_result_lrq.msg == 'region_data_sets required'
 
diff --git a/tests/integration/targets/cics_utilities/playbooks/failure.yml b/tests/integration/targets/cics_utilities/playbooks/failure.yml
@@ -36,11 +36,12 @@
       cics_version:
         CICS_HLQ: "{{ ds_name }}"
       register: result
-      failed_when: false
+      ignore_errors: true
 
     - name: Assert non-existent
       ansible.builtin.assert:
         that:
+          - result.failed is true
           - result is not changed
           - result.rc == 1
           - "'exception' in result"
@@ -121,11 +122,12 @@
       cics_version:
         CICS_HLQ: "{{ ds_name }}"
       register: result
-      failed_when: false
+      ignore_errors: true
 
     - name: Assert failed on empty Member
       ansible.builtin.assert:
         that:
+          - result.failed is true
           - result is not changed
           - result.rc != 0
           - "'exception' in result"
@@ -166,7 +168,6 @@
       cics_version:
         CICS_HLQ: "{{ ds_name }}"
       register: result
-      failed_when: false
 
     - name: Assert string content fails
       ansible.builtin.assert:
@@ -217,11 +218,12 @@
       cics_version:
         CICS_HLQ: "{{ ds_name }}"
       register: result
-      failed_when: false
+      ignore_errors: true
 
     - name: Assert status EOF fails
       ansible.builtin.assert:
         that:
+          - result.failed is true
           - result is not changed
           - result.rc != 0
           - "'exception' in result"
@@ -312,11 +314,12 @@
       cics_version:
         CICS_HLQ: "{{ ds_name }}"
       register: result
-      failed_when: false
+      ignore_errors: true
 
     - name: Assert Seq data set fails
       ansible.builtin.assert:
         that:
+          - result.failed is true
           - result is not changed
           - "'exception' in result"
 
