Skip to content

Commit b79021f

Browse files
authored
Fix inconsistent log snapshot and bump SDKs (#40)
1 parent 82ad1e3 commit b79021f

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

.yarn/sdks/typescript/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "typescript",
3-
"version": "5.4.3-sdk",
3+
"version": "5.4.5-sdk",
44
"main": "./lib/typescript.js",
55
"type": "commonjs",
66
"bin": {

src/index.cts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,16 +166,14 @@ export class TransformAsyncModulesPlugin implements WebpackPluginInstance {
166166
compilation.hooks.finishModules.tapPromise(
167167
PLUGIN_NAME,
168168
async (modules) => {
169+
const identifiers = [];
169170
const processes = [];
170171
for (const m of modules) {
171172
if (
172173
compilation.moduleGraph.isAsync(m) &&
173174
!this.#parsedTLAModules.has(m)
174175
) {
175-
logger.debug(
176-
"Adding and reprocessing dependencies for",
177-
m.readableIdentifier(shortener),
178-
);
176+
identifiers.push(m.readableIdentifier(shortener));
179177
processes.push(
180178
new Promise((resolve, reject) => {
181179
this.#addDependenciesToModule(m);
@@ -187,6 +185,10 @@ export class TransformAsyncModulesPlugin implements WebpackPluginInstance {
187185
);
188186
}
189187
}
188+
logger.debug(
189+
`Adding dependencies for ${identifiers.length} more modules:\n` +
190+
identifiers.sort().join("\n"),
191+
);
190192
await Promise.all(processes);
191193
},
192194
);

test/goodbye.spec.ts.snap

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@ exports[`Goodbye delay with node 0.12 target using runtime Compiles with correct
1616
"DEBUG LOG from TransformAsyncModulesPlugin
1717
Adding dependencies for top level await parsed in ./src/goodbye.js
1818
Adding dependencies for top level await parsed in ./src/another.js
19-
Adding and reprocessing dependencies for ./src/parent.js
20-
Adding and reprocessing dependencies for ./src/with2.js
19+
Adding dependencies for 2 more modules:
20+
./src/parent.js
21+
./src/with2.js
2122
Transforming module ./src/goodbye.js for chunk src_goodbye_js
2223
Transforming module ./src/goodbye.js for chunk src_parent_js
2324
Transforming module ./src/parent.js for chunk src_parent_js
@@ -44,8 +45,9 @@ exports[`Goodbye delay with node 6 target using runtime Compiles with correct de
4445
"DEBUG LOG from TransformAsyncModulesPlugin
4546
Adding dependencies for top level await parsed in ./src/goodbye.js
4647
Adding dependencies for top level await parsed in ./src/another.js
47-
Adding and reprocessing dependencies for ./src/parent.js
48-
Adding and reprocessing dependencies for ./src/with2.js
48+
Adding dependencies for 2 more modules:
49+
./src/parent.js
50+
./src/with2.js
4951
Transforming module ./src/goodbye.js for chunk src_goodbye_js
5052
Transforming module ./src/goodbye.js for chunk src_parent_js
5153
Transforming module ./src/parent.js for chunk src_parent_js

0 commit comments

Comments
 (0)