Skip to content

Commit 10c5b4d

Browse files
James Chenminggo
authored andcommitted
Uses better configuration for huawei optimization (cocos2d#17838)
* Uses better configuration for huawei optimization * Updates jar file and uncomment fps controlling code
1 parent 75a2395 commit 10c5b4d

File tree

2 files changed

+34
-34
lines changed

2 files changed

+34
-34
lines changed
Binary file not shown.

cocos/platform/android/jni/Java_org_cocos2dx_lib_Cocos2dxEngineDataManager.cpp

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,9 @@ bool _isFpsChanged = false;
111111
float _oldRealFps = 60.0f;
112112

113113
uint32_t _lowFpsCheckMode = 0; // 0: Continuous mode, 1: Average mode
114-
float _lowRealFpsThreshold = 0.25f; // Unit: percentage (0 ~ 1)
114+
float _lowRealFpsThreshold = 0.5f; // Unit: percentage (0 ~ 1)
115115
std::chrono::steady_clock::time_point _lastTimeNotifyLevelByLowFps; // Only used in continuous mode
116-
float _notifyLevelByLowFpsThreshold = 0.2f; // Unit: seconds, only used in continuous mode
116+
float _notifyLevelByLowFpsThreshold = 0.5f; // Unit: seconds, only used in continuous mode
117117
uint32_t _continuousLowRealFpsCount = 0; // Only used in continuous mode
118118
uint32_t _continuousLowRealFpsThreshold = 1; // Only used in continuous mode
119119
uint32_t _calculateAvgFpsCount = 0; // Only used in average mode
@@ -1223,38 +1223,38 @@ void EngineDataManager::nativeOnChangeLowFpsConfig(JNIEnv* env, jobject thiz, ji
12231223

12241224
void EngineDataManager::nativeOnChangeExpectedFps(JNIEnv* env, jobject thiz, jint fps)
12251225
{
1226-
// if (!_isSupported)
1227-
// return;
1228-
1229-
// if (fps < -1 || fps > 60)
1230-
// {
1231-
// LOGE("Setting fps (%d) isn't supported!", fps);
1232-
// return;
1233-
// }
1234-
1235-
// auto director = cocos2d::Director::getInstance();
1236-
// float defaultAnimationInterval = director->getAnimationInterval();
1237-
1238-
// int defaultFps = static_cast<int>(std::ceil(1.0f/defaultAnimationInterval));
1239-
1240-
// if (fps > defaultFps)
1241-
// {
1242-
// LOGD("nativeOnChangeExpectedFps, fps (%d) is greater than default fps (%d), reset it to default!", fps, defaultFps);
1243-
// fps = -1;
1244-
// }
1245-
1246-
// LOGD("nativeOnChangeExpectedFps, set fps: %d, default fps: %d", fps, defaultFps);
1247-
1248-
// if (fps > 0)
1249-
// {
1250-
// setAnimationIntervalBySystem(1.0f/fps);
1251-
// LOGD("nativeOnChangeExpectedFps, fps (%d) was set successfuly!", fps);
1252-
// }
1253-
// else if (fps == -1) // -1 means to reset to default FPS
1254-
// {
1255-
// setAnimationIntervalBySystem(-1.0f);
1256-
// LOGD("nativeOnChangeExpectedFps, fps (%d) was reset successfuly!", defaultFps);
1257-
// }
1226+
if (!_isSupported)
1227+
return;
1228+
1229+
if (fps < -1 || fps > 60)
1230+
{
1231+
LOGE("Setting fps (%d) isn't supported!", fps);
1232+
return;
1233+
}
1234+
1235+
auto director = cocos2d::Director::getInstance();
1236+
float defaultAnimationInterval = director->getAnimationInterval();
1237+
1238+
int defaultFps = static_cast<int>(std::ceil(1.0f/defaultAnimationInterval));
1239+
1240+
if (fps > defaultFps)
1241+
{
1242+
LOGD("nativeOnChangeExpectedFps, fps (%d) is greater than default fps (%d), reset it to default!", fps, defaultFps);
1243+
fps = -1;
1244+
}
1245+
1246+
LOGD("nativeOnChangeExpectedFps, set fps: %d, default fps: %d", fps, defaultFps);
1247+
1248+
if (fps > 0)
1249+
{
1250+
setAnimationIntervalBySystem(1.0f/fps);
1251+
LOGD("nativeOnChangeExpectedFps, fps (%d) was set successfuly!", fps);
1252+
}
1253+
else if (fps == -1) // -1 means to reset to default FPS
1254+
{
1255+
setAnimationIntervalBySystem(-1.0f);
1256+
LOGD("nativeOnChangeExpectedFps, fps (%d) was reset successfuly!", defaultFps);
1257+
}
12581258
}
12591259

12601260
void EngineDataManager::nativeOnChangeSpecialEffectLevel(JNIEnv* env, jobject thiz, jint level)

0 commit comments

Comments
 (0)