Skip to content

custom-binary plugin does not support whitespace #1031

@skyshineb

Description

@skyshineb

I've recently stuck with error on other project using this plugin.
I have git installed on Windows in C:\Program Files\Git with respective binary path C:\Program Files\Git\bin\git.exe and when SimpleGit is instantiated it receives this path as custom binary.
But it will not pass the Regex check ^([a-z]:)?([a-z0-9/.\\_-]+)$ in simple-git/src/lib/plugins/custom-binary.plugin.ts because it does not contain whitespace nor ~(to use with shorten windows path).

Can someone explain to me why this is desired behavior or maybe it's a bug?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions