Merge branch 'dev' into analytics

Author: mikecao

next.config.mjs

@@ -12,12 +12,8 @@ const cloudMode = process.env.CLOUD_MODE;
 const cloudUrl = process.env.CLOUD_URL;
 const corsMaxAge = process.env.CORS_MAX_AGE;
 const defaultLocale = process.env.DEFAULT_LOCALE;
-const disableLogin = process.env.DISABLE_LOGIN;
-const disableUI = process.env.DISABLE_UI;
-const faviconURL = process.env.FAVICON_URL;
 const forceSSL = process.env.FORCE_SSL;
 const frameAncestors = process.env.ALLOWED_FRAME_URLS ?? '';
-const privateMode = process.env.PRIVATE_MODE;
 const trackerScriptName = process.env.TRACKER_SCRIPT_NAME;
 const trackerScriptURL = process.env.TRACKER_SCRIPT_URL;
 
@@ -173,13 +169,11 @@ if (cloudMode && cloudUrl) {
     permanent: false,
   });
 
-  if (disableLogin) {
-    redirects.push({
-      source: '/login',
-      destination: cloudUrl,
-      permanent: false,
-    });
-  }
+  redirects.push({
+    source: '/login',
+    destination: cloudUrl,
+    permanent: false,
+  });
 }
 
 /** @type {import('next').NextConfig} */
@@ -191,10 +185,6 @@ export default {
     cloudUrl,
     currentVersion: pkg.version,
     defaultLocale,
-    disableLogin,
-    disableUI,
-    faviconURL,
-    privateMode,
   },
   basePath,
   output: 'standalone',

src/app/(main)/App.tsx

@@ -22,10 +22,6 @@ export function App({ children }) {
     return null;
   }
 
-  if (config.uiDisabled) {
-    return null;
-  }
-
   return (
     <>
       {children}

src/app/(main)/UpdateNotice.tsx

@@ -13,13 +13,14 @@ export function UpdateNotice({ user, config }) {
   const { latest, checked, hasUpdate, releaseUrl } = useStore();
   const pathname = usePathname();
   const [dismissed, setDismissed] = useState(checked);
+
   const allowUpdate =
     process.env.NODE_ENV === 'production' &&
     user?.isAdmin &&
     !config?.updatesDisabled &&
+    !config?.privateMode &&
     !pathname.includes('/share/') &&
     !process.env.cloudMode &&
-    !process.env.privateMode &&
     !dismissed;
 
   const updateCheck = useCallback(() => {

src/app/(main)/profile/LanguageSetting.tsx

@@ -9,6 +9,7 @@ export function LanguageSetting() {
   const [search, setSearch] = useState('');
   const { formatMessage, labels } = useMessages();
   const { locale, saveLocale } = useLocale();
+
   const options = search
     ? Object.keys(languages).filter(n => {
         return (

src/app/actions/getConfig.ts

@@ -1,10 +1,19 @@
 'use server';
 
-export async function getConfig() {
+export type Config = {
+  faviconUrl: string | undefined;
+  privateMode: boolean;
+  telemetryDisabled: boolean;
+  trackerScriptName: string | undefined;
+  updatesDisabled: boolean;
+};
+
+export async function getConfig(): Promise<Config> {
   return {
+    faviconUrl: process.env.FAVICON_URL,
+    privateMode: !!process.env.PRIVATE_MODE,
     telemetryDisabled: !!process.env.DISABLE_TELEMETRY,
     trackerScriptName: process.env.TRACKER_SCRIPT_NAME,
-    uiDisabled: !!process.env.DISABLE_UI,
     updatesDisabled: !!process.env.DISABLE_UPDATES,
   };
 }

src/app/api/scripts/telemetry/route.ts

@@ -2,25 +2,25 @@ import { CURRENT_VERSION, TELEMETRY_PIXEL } from '@/lib/constants';
 
 export async function GET() {
   if (
-    process.env.NODE_ENV !== 'production' &&
-    process.env.DISABLE_TELEMETRY &&
+    process.env.NODE_ENV !== 'production' ||
+    process.env.DISABLE_TELEMETRY ||
     process.env.PRIVATE_MODE
   ) {
-    const script = `
-    (()=>{const i=document.createElement('img');
-      i.setAttribute('src','${TELEMETRY_PIXEL}?v=${CURRENT_VERSION}');
-      i.setAttribute('style','width:0;height:0;position:absolute;pointer-events:none;');
-      document.body.appendChild(i);})();
-  `;
-
-    return new Response(script.replace(/\s\s+/g, ''), {
+    return new Response('/* telemetry disabled */', {
       headers: {
         'content-type': 'text/javascript',
       },
     });
   }
 
-  return new Response('/* telemetry disabled */', {
+  const script = `
+    (()=>{const i=document.createElement('img');
+      i.setAttribute('src','${TELEMETRY_PIXEL}?v=${CURRENT_VERSION}');
+      i.setAttribute('style','width:0;height:0;position:absolute;pointer-events:none;');
+      document.body.appendChild(i);})();
+  `;
+
+  return new Response(script.replace(/\s\s+/g, ''), {
     headers: {
       'content-type': 'text/javascript',
     },

src/app/layout.tsx

@@ -9,6 +9,14 @@ import '@/styles/index.css';
 import '@/styles/variables.css';
 
 export default function ({ children }) {
+  if (process.env.DISABLE_UI) {
+    return (
+      <html>
+        <body></body>
+      </html>
+    );
+  }
+
   return (
     <html lang="en" data-scroll="0">
       <head>

src/app/login/LoginPage.tsx

@@ -3,10 +3,6 @@ import LoginForm from './LoginForm';
 import styles from './LoginPage.module.css';
 
 export function LoginPage() {
-  if (process.env.disableLogin) {
-    return null;
-  }
-
   return (
     <div className={styles.page}>
       <LoginForm />

src/app/login/page.tsx

@@ -2,6 +2,10 @@ import { Metadata } from 'next';
 import LoginPage from './LoginPage';
 
 export default async function () {
+  if (process.env.DISABLE_LOGIN) {
+    return null;
+  }
+
   return <LoginPage />;
 }
 

src/app/logout/LogoutPage.tsx

@@ -6,9 +6,9 @@ import { setUser } from '@/store/app';
 import { removeClientAuthToken } from '@/lib/client';
 
 export function LogoutPage() {
-  const disabled = !!(process.env.disableLogin || process.env.cloudMode);
   const router = useRouter();
   const { post } = useApi();
+  const disabled = process.env.cloudMode;
 
   useEffect(() => {
     async function logout() {