Skip to content

Commit 9a269ab

Browse files
authored
Merge pull request umami-software#3805 from prince0xdev/feat/mobile-navigation-improvement
Improve mobile navigation: clickable “online” badge & page title
2 parents a19b92a + beb2bc0 commit 9a269ab

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+85
-12
lines changed

src/app/(main)/websites/[websiteId]/WebsiteHeader.tsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,19 @@ export function WebsiteHeader({ showActions }: { showActions?: boolean }) {
1313
const { renderUrl, pathname } = useNavigation();
1414
const isSettings = pathname.endsWith('/settings');
1515

16+
const { formatMessage, labels } = useMessages();
17+
1618
if (isSettings) {
1719
return null;
1820
}
1921

2022
return (
21-
<PageHeader title={website.name} icon={<Favicon domain={website.domain} />} marginBottom="3">
23+
<PageHeader
24+
title={website.name}
25+
icon={<Favicon domain={website.domain} />}
26+
marginBottom="3"
27+
titleHref={renderUrl(`/websites/${website.id}`, false)}
28+
>
2229
<Row alignItems="center" gap="6" wrap="wrap">
2330
<ActiveUsers websiteId={website.id} />
2431

@@ -29,7 +36,7 @@ export function WebsiteHeader({ showActions }: { showActions?: boolean }) {
2936
<Icon>
3037
<Edit />
3138
</Icon>
32-
<Text>Edit</Text>
39+
<Text>{formatMessage(labels.edit)}</Text>
3340
</LinkButton>
3441
</Row>
3542
)}

src/components/common/PageHeader.tsx

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
11
import { ReactNode } from 'react';
22
import { Heading, Icon, Row, Text, Column, Grid } from '@umami/react-zen';
3+
import { LinkButton } from './LinkButton';
34

45
export function PageHeader({
56
title,
67
description,
78
label,
89
icon,
910
showBorder = true,
11+
titleHref,
1012
children,
1113
}: {
1214
title: string;
1315
description?: string;
1416
label?: ReactNode;
1517
icon?: ReactNode;
1618
showBorder?: boolean;
19+
titleHref?: string;
1720
allowEdit?: boolean;
1821
className?: string;
1922
children?: ReactNode;
@@ -33,7 +36,13 @@ export function PageHeader({
3336
{icon}
3437
</Icon>
3538
)}
36-
{title && <Heading size={{ xs: '2', md: '3', lg: '4' }}>{title}</Heading>}
39+
{title && titleHref ? (
40+
<LinkButton href={titleHref} variant="quiet">
41+
<Heading size={{ xs: '2', md: '3', lg: '4' }}>{title}</Heading>
42+
</LinkButton>
43+
) : (
44+
title && <Heading size={{ xs: '2', md: '3', lg: '4' }}>{title}</Heading>
45+
)}
3746
</Row>
3847
{description && (
3948
<Text color="muted" truncate style={{ maxWidth: 600 }} title={description}>

src/components/metrics/ActiveUsers.tsx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { useMemo } from 'react';
22
import { Text, StatusLight } from '@umami/react-zen';
33
import { useMessages, useActyiveUsersQuery } from '@/components/hooks';
4+
import { LinkButton } from '@/components/common/LinkButton';
45

56
export function ActiveUsers({
67
websiteId,
@@ -27,10 +28,12 @@ export function ActiveUsers({
2728
}
2829

2930
return (
30-
<StatusLight variant="success">
31-
<Text size="2" weight="medium">
32-
{count} {formatMessage(labels.online)}
33-
</Text>
34-
</StatusLight>
31+
<LinkButton href={`/websites/${websiteId}/realtime`} variant="quiet">
32+
<StatusLight variant="success">
33+
<Text size="2" weight="medium">
34+
{count} {formatMessage(labels.online)}
35+
</Text>
36+
</StatusLight>
37+
</LinkButton>
3538
);
3639
}

src/lang/ar-SA.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,7 @@
289289
"label.websites": "المواقع",
290290
"label.window": "النافذة",
291291
"label.yesterday": "الأمس",
292+
"label.behavior": "السلوك",
292293
"message.action-confirmation": "اكتب {confirmation} في المربع أدناه للتأكيد.",
293294
"message.active-users": "{x} حاليا {x, plural, one {زائر واحد} other {زوار}}",
294295
"message.bad-request": "Bad request",

src/lang/be-BY.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"label.average": "Сярэдняе",
2121
"label.back": "Назад",
2222
"label.before": "Да",
23+
"label.behavior": "Паводзіны",
2324
"label.boards": "Дошкі",
2425
"label.bounce-rate": "Паказчык адмоваў",
2526
"label.breakdown": "Разбіўка",

src/lang/bg-BG.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"label.average": "Средно",
2121
"label.back": "Назад",
2222
"label.before": "Преди",
23+
"label.behavior": "Поведение",
2324
"label.boards": "Дъски",
2425
"label.bounce-rate": "Kоефициент на отказ",
2526
"label.breakdown": "Разбивка",

src/lang/bn-BD.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"label.average": "গড়",
2121
"label.back": "পেছনে",
2222
"label.before": "পূর্বে",
23+
"label.behavior": "আচরণ",
2324
"label.boards": "বোর্ডসমূহ",
2425
"label.bounce-rate": "উপরে উঠার হার",
2526
"label.breakdown": "ভাঙ্গন",

src/lang/bs-BA.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"label.average": "Prosjek",
2121
"label.back": "Nazad",
2222
"label.before": "Prije",
23+
"label.behavior": "Ponašanje",
2324
"label.boards": "Ploče",
2425
"label.bounce-rate": "Stopa napuštanja",
2526
"label.breakdown": "Pregled po kategorijama",

src/lang/ca-ES.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"label.average": "Mitjana",
2121
"label.back": "Enrere",
2222
"label.before": "Abans",
23+
"label.behavior": "Comportament",
2324
"label.boards": "Taulers",
2425
"label.bounce-rate": "Percentatge de rebot",
2526
"label.breakdown": "Desglossament",

src/lang/cs-CZ.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"label.average": "Průměr",
2121
"label.back": "Zpět",
2222
"label.before": "Před",
23+
"label.behavior": "Chování",
2324
"label.boards": "Nástěnky",
2425
"label.bounce-rate": "Okamžité opuštění",
2526
"label.breakdown": "Rozpis",

0 commit comments

Comments
 (0)