Skip to content

Commit ce0c313

Browse files
authored
Merge pull request #3 from stillie/main
Main
2 parents 23c5a28 + aefba43 commit ce0c313

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@
2828
- [X] Please do not perform dependency override
2929
- [X] The architectures options are: Bloc, Cubit and Provider + ChangeNotifier/StateNotifier
3030
- [X] If you use Bloc or Cubit as your architecture, please use flutter_bloc or your custom solution
31-
- [ ] Please provide a comprehensive ReadME which contains:
31+
- [X] Please provide a comprehensive ReadME which contains:
3232
- [X] Conventions, architecture, and general considerations
3333
- [X] Exhaustive list of third-parties alongside their respective purposes
3434
- [X] How to build the project
35-
- [ ] Any additional notes that can demonstrate your knowledge
35+
- [X] Any additional notes that can demonstrate your knowledge
3636

3737
* 7 Days to complete
3838

@@ -67,4 +67,5 @@ Dev Dependencies:
6767
- I wanted to implement better error handling. I started implementing it for the location errors but didn't have enough time to complete that
6868
- I wanted to improve the visual aspect of a loading indicator
6969
- I made some changes to the colours given in the documentation due to the fact that it didnt quite match up to the style of the image (for the sunny screenshot)
70-
- I have implemented GitHub actions which will run the tests and then build the app. It won't build the app if any of the tests have failed.
70+
- I have implemented GitHub actions which will run the tests and then build the app. It won't build the app if any of the tests have failed.
71+
- When a change is made on the 'Release' branch. A github Action is executed which builds that APK and publishes it to the [Releases](https://github.com/stillie/weather-app/releases) page of the repo. You are able to download the files from there.

0 commit comments

Comments
 (0)