Fix Clang compile warnings from 3.98 (#510)

* [Codex] Fix macOS/clang data_serialization (no test gating)

* [Revert] lns::fraction() implemented by Codex

Author: loren-osborn

applications/performance/stream/stream.cpp

@@ -194,9 +194,9 @@ try {
 
 	ReportTestSuiteHeader(test_suite, reportTestCases);
 
+#if MANUAL_TESTING
 	size_t startSample = 11;
 	size_t endSample = 13;
-#if MANUAL_TESTING
 	Sweep<float>(startSample, endSample);
 	Sweep < fixpnt<8, 4> >(startSample, endSample);
 
@@ -215,23 +215,23 @@ try {
 #endif
 
 #if REGRESSION_LEVEL_2
-	startSample = 10;
-	endSample   = 11;  // just one pass through the operators
+	size_t startSample = 10;
+	size_t endSample   = 11;  // just one pass through the operators
 	Sweep<float>(startSample, endSample);
 	Sweep<cfloat<32, 8, std::uint32_t, true, false, false>>(startSample, endSample);
 #endif
 
 #if REGRESSION_LEVEL_3
-	startSample = 10;
-	endSample   = 11;  // just one pass through the operators
+	size_t startSample = 10;
+	size_t endSample   = 11;  // just one pass through the operators
 	Sweep<int>(startSample, endSample);
 	Sweep<float>(startSample, endSample);
 	Sweep<double>(startSample, endSample);
 #endif
 
 #if REGRESSION_LEVEL_4
-	startSample = 10;
-	endSample   = 11;  // just one pass through the operators
+	size_t startSample = 10;
+	size_t endSample   = 11;  // just one pass through the operators
 	Sweep<int>(startSample, endSample);
 	Sweep<float>(startSample, endSample);
 	Sweep<double>(startSample, endSample);

applications/precision/numeric/midpoint.cpp

@@ -82,11 +82,11 @@ try {
 
 	std::cout << "lerp and midpoint operators\n";
 
-	using int32    = integer<32>;
-	using fixpnt32 = fixpnt<32,16>;
-	using posit32  = posit<32,2>;
-	using areal32  = areal<32,8>;
-	using lns32    = lns<32,23>;
+	//using int32    = integer<32>;
+	//using fixpnt32 = fixpnt<32,16>;
+	//using posit32  = posit<32,2>;
+	//using areal32  = areal<32,8>;
+	//using lns32    = lns<32,23>;
 
 	// check difficult midpoint and lerp operations on different number systems
 

applications/precision/tapered/error_propagation.cpp

@@ -76,7 +76,7 @@ try {
 	constexpr double x_max = 1.01;
 	constexpr double x_step = (x_max - x_min) / nrSamples;
 	double x = x_min;
-	qd qa(x_step), q_step(x_step), qb;
+	qd qa(x_step), qb;
 	Posit pa(x_step), p_step(x_step), pb;
 	Cfloat ca(x_step), c_step(x_step), cb;
 	Lns la(x_step), l_step(x_step), lb;

benchmark/energy/instrumented/mixed_precision_blas_demo.cpp

@@ -75,7 +75,6 @@ void demonstrateGEMM() {
 
     // Posit16 with Posit32 accumulator
     using p16 = posit<16, 1>;
-    using p32 = posit<32, 2>;
     std::vector<p16> A_p16(A_double.begin(), A_double.end());
     std::vector<p16> B_p16(B_double.begin(), B_double.end());
     std::vector<p16> C_p16(m * n, p16(0));
@@ -193,7 +192,7 @@ void demonstrateAccuracyVsEnergy() {
         std::vector<float> x_f32(x.begin(), x.end());
         std::vector<float> y_f32(y.begin(), y.end());
         MixedPrecisionStats stats_f32;
-        auto result_f32 = mp_dot<MP_FP32_Only>(x_f32, y_f32, &stats_f32);
+        mp_dot<MP_FP32_Only>(x_f32, y_f32, &stats_f32);
 
         // FP16+FP32acc
         std::vector<half> x_f16(x.begin(), x.end());

include/sw/blas/mixed_precision.hpp

@@ -100,7 +100,6 @@ mp_dot(const std::vector<typename MPC::input_type>& x,
        const std::vector<typename MPC::input_type>& y,
        MixedPrecisionStats* stats = nullptr) {
 
-    using InputT = typename MPC::input_type;
     using ComputeT = typename MPC::compute_type;
     using AccumT = typename MPC::accumulator_type;
     using OutputT = typename MPC::output_type;
@@ -144,7 +143,6 @@ void mp_gemm(size_t m, size_t n, size_t k,
              std::vector<typename MPC::output_type>& C,
              MixedPrecisionStats* stats = nullptr) {
 
-    using InputT = typename MPC::input_type;
     using ComputeT = typename MPC::compute_type;
     using AccumT = typename MPC::accumulator_type;
     using OutputT = typename MPC::output_type;
@@ -279,10 +277,8 @@ double estimateMixedPrecisionEnergy(const MixedPrecisionStats& stats,
         return BitWidth::bits_64;
     };
 
-    BitWidth input_bw = toBitWidth(MPC::input_bits);
     BitWidth compute_bw = toBitWidth(MPC::compute_bits);
     BitWidth accum_bw = toBitWidth(MPC::accum_bits);
-    BitWidth output_bw = toBitWidth(MPC::output_bits);
 
     double energy = 0.0;
 
@@ -508,4 +504,3 @@ inline void reportMixedPrecisionBenchmark(std::ostream& os,
 }
 
 }} // namespace sw::blas
-

linalg/data/test_matrices.cpp

@@ -27,7 +27,7 @@ namespace sw { namespace blas {
 		fo.close();
 	}
 
-	static void GenerateMatrixDataFiles(const std::vector<std::string>& testMatrixNames) {
+	[[maybe_unused]] static void GenerateMatrixDataFiles(const std::vector<std::string>& testMatrixNames) {
 		for (auto matrixName : testMatrixNames) {
 			WriteMatrixDataFile(matrixName + std::string(".dat"), getTestMatrix(matrixName));
 		}

static/areal/standard/double_precision.cpp

@@ -369,9 +369,6 @@ int ValidateSubnormalConversion(bool reportTestCases) {
 		bool exact = (roundtrip == subnormal);
 		bool isUncertain = (a.block(0) & 1) != 0;
 
-		// Calculate relative error
-		double relError = (subnormal != 0.0) ? std::abs((roundtrip - subnormal) / subnormal) : 0.0;
-
 		// The conversion should be correct if:
 		// 1. The value is exact (no ubit set), OR
 		// 2. The ubit is set (indicating uncertainty due to precision loss)

static/posit/api/api.cpp

@@ -213,8 +213,8 @@ try {
 	// parsing of text input
 	{
 		// TODO: implement parse
-		constexpr unsigned nbits = 128;
-		constexpr unsigned es = 2;
+		//constexpr unsigned nbits = 128;
+		//constexpr unsigned es = 2;
 		//parse<nbits, es> a, b, c, d;
 		//a.assign("123456789.987654321");
 		//parse("123456789.987654321", b);