Unsubscribe from the channel when UpdatesForElement disconnects (#299)

farolanf · web-flow · commit f75817022dd7 · 2024-11-09T23:57:42.000+01:00
Unsubscribe from the channel by calling superclass's (SubscribingElement) disconnectedCallback.

## Why should this be added
Fix repeated subscribe messages after a morph.
diff --git a/javascript/elements/updates_for_element.js b/javascript/elements/updates_for_element.js
@@ -64,6 +64,7 @@ export default class UpdatesForElement extends SubscribingElement {
   }
 
   disconnectedCallback () {
+    super.disconnectedCallback()
     if (this.observeAppearance) {
       this.appearanceObserver.stop()
     }

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@ export default class UpdatesForElement extends SubscribingElement {`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`disconnectedCallback () {`
	`67`	`+ super.disconnectedCallback()`
`67`	`68`	`if (this.observeAppearance) {`
`68`	`69`	`this.appearanceObserver.stop()`
`69`	`70`	`}`