Skip to content

Commit 0525d2d

Browse files
authored
Remove Serial::split (#351)
1 parent 483a8e5 commit 0525d2d

File tree

4 files changed

+10
-361
lines changed

4 files changed

+10
-361
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
2626
- Add `num_traits::PrimInt` bounds to `Word`
2727
- Remove `Serial::split`, which possibly creates two mutable references two
2828
one Serial instance, which could've caused UB. The use case of this function
29-
was hard to find out anyway. ([#352])
29+
was hard to find out anyway. ([#351])
3030

3131
### Added
3232

@@ -610,6 +610,7 @@ let clocks = rcc
610610
[filter]: https://defmt.ferrous-systems.com/filtering.html
611611

612612
[#352]: https://github.com/stm32-rs/stm32f3xx-hal/pull/352
613+
[#351]: https://github.com/stm32-rs/stm32f3xx-hal/pull/351
613614
[#345]: https://github.com/stm32-rs/stm32f3xx-hal/pull/345
614615
[#346]: https://github.com/stm32-rs/stm32f3xx-hal/pull/346
615616
[#347]: https://github.com/stm32-rs/stm32f3xx-hal/pull/347

src/dma.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -571,8 +571,6 @@ dma!( 2: { 1,2,3,4,5 } );
571571
/// Marker trait mapping DMA targets to their channels
572572
pub trait OnChannel<C: Channel>: Target + crate::private::Sealed {}
573573

574-
use crate::serial::{RxPin, TxPin};
575-
576574
macro_rules! on_channel {
577575
(
578576
$(
@@ -581,10 +579,6 @@ macro_rules! on_channel {
581579
) => {
582580
$(
583581
$(
584-
impl<Pin> crate::private::Sealed for serial::Tx<$USART, Pin> {}
585-
impl<Pin> OnChannel<$dma::$TxChannel> for serial::Tx<$USART, Pin> where Pin: TxPin<$USART> {}
586-
impl<Pin> crate::private::Sealed for serial::Rx<$USART, Pin> {}
587-
impl<Pin> OnChannel<$dma::$RxChannel> for serial::Rx<$USART, Pin> where Pin: RxPin<$USART> {}
588582
impl<Tx, Rx> crate::private::Sealed for serial::Serial<$USART, (Tx, Rx)> {}
589583
impl<Tx, Rx> OnChannel<$dma::$TxChannel> for serial::Serial<$USART, (Tx, Rx)> {}
590584
impl<Tx, Rx> OnChannel<$dma::$RxChannel> for serial::Serial<$USART, (Tx, Rx)> {}

0 commit comments

Comments
 (0)