Remove unproven feature

Author: Sh3Rm4n

.github/workflows/ci.yml

@@ -92,6 +92,22 @@ jobs:
           command: check
           args: --features=stm32f303xc,stm32-usbd,rt,can,ld --lib --examples
 
+  check-minimal-feature-set:
+    name: Check minimal feature set
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          target: thumbv7em-none-eabihf
+          override: true
+          profile: minimal
+      - uses: actions-rs/cargo@v1
+        with:
+          command: check
+          args: --no-default-features --features=stm32f303xc --lib --examples
+
   build-testsuite:
     name: Build Testsuite
     runs-on: ubuntu-latest

CHANGELOG.md

@@ -26,6 +26,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Each pin aliases (`PA0`, `PA1`, ..) are defined under `gpio` module directly.
   Re-export from gpio port sub-modules are provided for compatibility. [#257]
 
+### Fixed
+
+- The "unproven" feature, which itself does enable the "embedded-hal/unproven"
+  features, can no longer be disabled. ([#259])
+  1. The "unproven" features are no longer unproven and used anywhere anyways.
+  2. This crate was not building successfully without the unproven feature.
+
 ### Breaking Changes
 
 - Refactor CAN to use the [`bxCan`](https://github.com/stm32-rs/bxcan) crate. ([#207])
@@ -360,6 +367,7 @@ let clocks = rcc
 [defmt]: https://github.com/knurling-rs/defmt
 [filter]: https://defmt.ferrous-systems.com/filtering.html
 
+[#259]: https://github.com/stm32-rs/stm32f3xx-hal/pull/259
 [#257]: https://github.com/stm32-rs/stm32f3xx-hal/pull/257
 [#255]: https://github.com/stm32-rs/stm32f3xx-hal/pull/255
 [#252]: https://github.com/stm32-rs/stm32f3xx-hal/pull/252

Cargo.toml

@@ -38,7 +38,7 @@ cortex-m = "0.7.2"
 cortex-m-rt = "0.6.14"
 defmt = { version = "0.2.2", optional = true }
 embedded-dma = "0.1.2"
-embedded-hal = "0.2.5"
+embedded-hal = { version = "0.2.5", features = ["unproven"] }
 embedded-time = "0.12.0"
 nb = "1.0.0"
 paste = "1.0.5"
@@ -68,8 +68,6 @@ cargo_metadata = "0.13.1"
 slice-group-by = "0.2.6"
 
 [features]
-default = ["unproven"]
-unproven = ["embedded-hal/unproven"]
 device-selected = []
 direct-call-deprecated = []
 ld = []

src/gpio.rs

@@ -69,7 +69,6 @@ use crate::{
     syscfg::SysCfg,
 };
 
-#[cfg(feature = "unproven")]
 use crate::hal::digital::v2::{toggleable, InputPin, StatefulOutputPin};
 
 /// Extension trait to split a GPIO peripheral in independent pins and registers
@@ -499,7 +498,6 @@ where
     }
 }
 
-#[cfg(feature = "unproven")]
 impl<Gpio, Index, Mode> InputPin for Pin<Gpio, Index, Mode>
 where
     Gpio: marker::Gpio,
@@ -518,7 +516,6 @@ where
     }
 }
 
-#[cfg(feature = "unproven")]
 impl<Gpio, Index, Otype> StatefulOutputPin for Pin<Gpio, Index, Output<Otype>>
 where
     Gpio: marker::Gpio,
@@ -534,7 +531,6 @@ where
     }
 }
 
-#[cfg(feature = "unproven")]
 impl<Gpio, Index, Otype> toggleable::Default for Pin<Gpio, Index, Output<Otype>>
 where
     Gpio: marker::Gpio,

src/prelude.rs

@@ -17,7 +17,6 @@ pub use crate::rcc::RccExt as _stm32f3xx_hal_rcc_RccExt;
 pub use crate::syscfg::SysCfgExt as _stm32f3xx_hal_syscfg_SysCfgExt;
 pub use crate::time::duration::Extensions as _stm32f3xx_hal_time_time_Extensions;
 pub use crate::time::rate::Extensions as _stm32f3xx_hal_time_rate_Extensions;
-#[cfg(feature = "unproven")]
 pub use crate::{
     hal::digital::v2::InputPin as _embedded_hal_digital_InputPin,
     hal::digital::v2::OutputPin as _embedded_hal_digital_OutputPin,