Remove timeout from Tim::new()

Author: Sh3Rm4n

CHANGELOG.md

@@ -57,9 +57,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
   the newly introduced `InterruptNumber` trait, where the `Interrupt` is held
   as an associated const. ([#267])
   - Depending on the timer one `Interrupt` or a bundle of `InterruptTypes` is
-      returned.
+    returned.
   - On the bases of these interrupts, the interrupt controller (NVIC) can
-      be set to mask or unmask these interrupts.
+    be set to mask or unmask these interrupts.
 
 [`enumset`]: https://crates.io/crates/enumset
 
@@ -132,6 +132,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
   - `Timer::tim1` and so on are renamed to `Timer::new`
   - The implementation of the timers are corrected to better represent the
     avaibilities of timers of the hardware.
+  - `Timer::new` now does not take a timeout value. This means, that the
+    timer will now not be started automatically and one has to explicitly call
+    `start()`.
 
 ## [v0.7.0] - 2021-06-18
 

src/timer.rs

@@ -104,18 +104,10 @@ where
     TIM: Instance,
 {
     /// Configures a TIM peripheral as a periodic count down timer
-    pub fn new<T>(tim: TIM, timeout: T, clocks: Clocks, apb: &mut <TIM as Instance>::APB) -> Self
-    where
-        T: Into<Hertz>,
-    {
+    pub fn new(tim: TIM, clocks: Clocks, apb: &mut <TIM as Instance>::APB) -> Self {
         TIM::enable_clock(apb);
 
-        let mut timer = Timer { clocks, tim };
-
-        // Should we really start the timer here?
-        timer.start(timeout);
-
-        timer
+        Timer { clocks, tim }
     }
 
     /// Stops the timer

testsuite/tests/timer.rs

@@ -40,7 +40,7 @@ mod tests {
         let clocks = rcc.cfgr.freeze(&mut flash.acr);
 
         // Let's use a timer, which is avaliable for every chip
-        let timer = Timer::new(dp.TIM2, 1.Hz(), clocks, &mut rcc.apb1);
+        let timer = Timer::new(dp.TIM2, clocks, &mut rcc.apb1);
         let mono_timer = MonoTimer::new(cp.DWT, clocks, &mut cp.DCB);
 
         assert!(mono_timer.frequency() == clocks.hclk());
@@ -59,7 +59,7 @@ mod tests {
     fn test_stop_and_free(state: &mut State) {
         let timer = state.timer.take().unwrap().free();
 
-        let timer = Timer::new(timer, 100.Hz(), state.clocks, &mut state.apb1);
+        let timer = Timer::new(timer, state.clocks, &mut state.apb1);
 
         state.timer = Some(timer);
     }