Review comments and various fixes

Author: Piroro-hs

CHANGELOG.md

@@ -9,17 +9,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Added
 
-- Replace custom time based units with types defined in the [embedded-time][]
-  crate ([#192])
 - Make `Clocks` `ppre1()` and `ppre2()` methods public, to get the current
   Prescaler value. ([#210])
 - Implement `into_xxx` methods for partially erased pins ([#189])
 - Enable better GPIO internal resistor configuration ([#189])
 - Support for GPIO output slew rate configuration ([#189])
 - Support for GPIO interrupts ([#189])
 
-[embedded-time]: https://github.com/FluenTech/embedded-time/
-
 ### Changed
 
 - Added support for more CAN bit rates and modes. ([#186])
@@ -33,10 +29,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Breaking Changes
 
+- Replace custom time based units with types defined in the [embedded-time][]
+  crate ([#192])
 - The `rcc` public API now expects time based units in `Megahertz`.
   If the supplied frequency cannot be converted to `Hertz` the code
   will `panic`. This will occur if the supplied `Megahertz` frequency
-  cannot fit into `u32::MAX` when converting to `Hertz`
+  cannot fit into `u32::MAX` when converting to `Hertz` ([#192])
 
 ```rust
 // The supplied frequencies must be in `MHz`.
@@ -55,9 +53,10 @@ let clocks = rcc
   - `cortex-m` to 0.7
   - `stm32-usbd` to 0.6
   - `defmt` to 0.2
-
 - `into_afx` methods are splitted into `into_afx_push_pull` and
   `into_afx_open_drain` ([#189])
+- GPIO output mode (`PushPull` or `OpenDrain`) is encoded into pin typestate
+  in alternate function mode ([#189])
 - GPIO internal resistor configuration is no longer encoded into pin typestate
   in input mode ([#189])
 
@@ -95,9 +94,6 @@ let clocks = rcc
     The support of this feature is subject to change as the development
     of [defmt][] is advancing.
 
-[defmt]: https://github.com/knurling-rs/defmt
-[filter]: https://defmt.ferrous-systems.com/filtering.html
-
 ### Changed
 
 - Introduced auto-generated GPIO mappings based on the STM32CubeMX database
@@ -109,8 +105,6 @@ let clocks = rcc
   ([#152])
 - Wrong I2C clock source ([#164])
 
-[#151]: https://github.com/stm32-rs/stm32f3xx-hal/issues/151
-
 ### Breaking Changes
 
 - Removed impl for `SckPin<SPI2>` for `PB13<AF5>` from `stm32f328` and
@@ -315,6 +309,10 @@ let clocks = rcc
 
 - Support `stm32f303` device
 
+[embedded-time]: https://github.com/FluenTech/embedded-time/
+[defmt]: https://github.com/knurling-rs/defmt
+[filter]: https://defmt.ferrous-systems.com/filtering.html
+
 [#211]: https://github.com/stm32-rs/stm32f3xx-hal/pull/211
 [#210]: https://github.com/stm32-rs/stm32f3xx-hal/pull/210
 [#208]: https://github.com/stm32-rs/stm32f3xx-hal/pull/208

examples/gpio_interrupts.rs

@@ -12,7 +12,7 @@ use cortex_m_rt::entry;
 use hal::gpio::{gpioa, gpioe, Edge, Input, Output, PushPull};
 use hal::interrupt;
 use hal::pac;
-use hal::pac::{Interrupt, NVIC};
+use hal::pac::NVIC;
 use hal::prelude::*;
 
 type LedPin = gpioe::PE9<Output<PushPull>>;
@@ -21,7 +21,7 @@ static LED: Mutex<RefCell<Option<LedPin>>> = Mutex::new(RefCell::new(None));
 type ButtonPin = gpioa::PA0<Input>;
 static BUTTON: Mutex<RefCell<Option<ButtonPin>>> = Mutex::new(RefCell::new(None));
 
-// When the user button is pressed. The north LED with toggle.
+// When the user button is pressed. The north LED will toggle.
 #[entry]
 fn main() -> ! {
     // Getting access to registers we will need for configuration.
@@ -48,10 +48,12 @@ fn main() -> ! {
     user_button.make_interrupt_source(&mut syscfg);
     user_button.trigger_on_edge(&mut exti, Edge::Rising);
     user_button.enable_interrupt(&mut exti);
+    let interrupt_num = user_button.nvic(); // hal::pac::Interrupt::EXTI0
+
     // Moving ownership to the global BUTTON so we can clear the interrupt pending bit.
     cortex_m::interrupt::free(|cs| *BUTTON.borrow(cs).borrow_mut() = Some(user_button));
 
-    unsafe { NVIC::unmask(Interrupt::EXTI0) };
+    unsafe { NVIC::unmask(interrupt_num) };
 
     loop {
         asm::wfi();