Skip to content

Commit 2cb6ed0

Browse files
committed
Fix example for smaller processors
1 parent 5f3855e commit 2cb6ed0

File tree

2 files changed

+10
-15
lines changed

2 files changed

+10
-15
lines changed

examples/opamp.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
use stm32g4xx_hal::adc::AdcClaim;
77
use stm32g4xx_hal::adc::ClockSource;
88
use stm32g4xx_hal::gpio::gpioa::*;
9-
use stm32g4xx_hal::gpio::gpiob::*;
109
use stm32g4xx_hal::gpio::Analog;
1110
use stm32g4xx_hal::opamp::opamp1::IntoPga as _;
1211
use stm32g4xx_hal::opamp::opamp2::IntoPga as _;
@@ -36,22 +35,20 @@ fn main() -> ! {
3635
let gpiob = dp.GPIOB.split(&mut rcc);
3736

3837
// setup opamps
39-
let (opamp1, opamp2, opamp3, opamp4, ..) = dp.OPAMP.split(&mut rcc);
38+
let (opamp1, opamp2, opamp3, ..) = dp.OPAMP.split(&mut rcc);
4039

4140
// Set up opamp1 and opamp2 in follower mode
4241
let opamp1 = opamp1.follower(gpioa.pa1, Some(gpioa.pa2));
4342
let opamp2 = opamp2.follower(gpioa.pa7, Option::<PA6<Analog>>::None);
4443

4544
// Set up opamp1 and opamp2 in open loop mode
4645
let opamp3 = opamp3.open_loop(gpiob.pb0, gpiob.pb2, Some(gpiob.pb1));
47-
let opamp4 = opamp4.open_loop(gpiob.pb11, gpiob.pb10, Option::<PB12<Analog>>::None);
4846

4947
// disable opamps
5048
let (opamp1, pa1, some_pa2) = opamp1.disable();
5149
let (opamp2, pa7, _none) = opamp2.disable();
5250

5351
let (_opamp3, _pb0, _pb2, _some_pb1) = opamp3.disable();
54-
let (_opamp4, _pb11, _pb10, _none) = opamp4.disable();
5552

5653
// Configure opamp1 with pa1 as non-inverting input and set gain to x2
5754
let _opamp1 = opamp1.pga(

src/adc.rs

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2351,27 +2351,25 @@ adc_pins!(
23512351
);
23522352

23532353
// See https://www.st.com/resource/en/reference_manual/rm0440-stm32g4-series-advanced-armbased-32bit-mcus-stmicroelectronics.pdf#page=782
2354-
#[cfg(any(
2355-
feature = "stm32g473",
2356-
feature = "stm32g474",
2357-
feature = "stm32g483",
2358-
feature = "stm32g484",
2359-
))]
23602354
adc_op!(
23612355
// TODO: Add all opamp types: Follower, OpenLoop
23622356
// TODO: Should we restrict type parameters A and B?
23632357
// TODO: Also allow AD-channels shared by pins
2364-
23652358
opamp::opamp1::Pga<A, B> => (ADC1, 13),
2366-
23672359
opamp::opamp2::Pga<A, B> => (ADC2, 16),
2368-
23692360
opamp::opamp3::Pga<A, B> => (ADC2, 18),
2361+
);
23702362

2363+
#[cfg(any(
2364+
feature = "stm32g471",
2365+
feature = "stm32g473",
2366+
feature = "stm32g474",
2367+
feature = "stm32g483",
2368+
feature = "stm32g484",
2369+
))]
2370+
adc_op!(
23712371
opamp::opamp4::Pga<A, B> => (ADC5, 5),
2372-
23732372
opamp::opamp5::Pga<A, B> => (ADC5, 3),
2374-
23752373
opamp::opamp6::Pga<A, B> => (ADC4, 17),
23762374
);
23772375

0 commit comments

Comments
 (0)