Comparator does not need to consume its positive input pin

Author: usbalbin

examples/comp.rs

@@ -38,15 +38,15 @@ fn main() -> ! {
 
     let pa1 = gpioa.pa1.into_analog();
     let pa0 = gpioa.pa0.into_analog();
-    let comp1 = comp1.comparator(pa1, pa0, Config::default(), &rcc.clocks);
+    let comp1 = comp1.comparator(&pa1, pa0, Config::default(), &rcc.clocks);
     let comp1 = comp1.enable();
 
     // led1 pa1 will be updated manually when to match comp1 value
     let mut led1 = gpioa.pa5.into_push_pull_output();
 
     let pa7 = gpioa.pa7.into_analog();
     let comp2 = comp2.comparator(
-        pa7,
+        &pa7,
         RefintInput::VRefintM12,
         Config::default()
             .hysteresis(Hysteresis::None)

examples/comp_w_dac.rs

@@ -44,7 +44,7 @@ fn main() -> ! {
 
     // Set up comparator with pa1 as positive, and the DAC as negative input
     let comp = comp1.comparator(
-        pa1,
+        &pa1,
         &dac,
         comparator::Config::default().hysteresis(comparator::Hysteresis::None),
         &rcc.clocks,

src/comparator.rs

@@ -228,13 +228,13 @@ window_input_pin!(COMP2, Comp1InP);
 
 macro_rules! positive_input_pin {
     ($COMP:ident, $pin_0:ident, $pin_1:ident) => {
-        impl PositiveInput<$COMP> for $pin_0<Analog> {
+        impl PositiveInput<$COMP> for &$pin_0<Analog> {
             fn setup(&self, comp: &$COMP) {
                 comp.csr().modify(|_, w| w.inpsel().bit(false))
             }
         }
 
-        impl PositiveInput<$COMP> for $pin_1<Analog> {
+        impl PositiveInput<$COMP> for &$pin_1<Analog> {
             fn setup(&self, comp: &$COMP) {
                 comp.csr().modify(|_, w| w.inpsel().bit(true))
             }