Export PwrExt In Prelude #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems to have been that way for quite some time https://github.com/stm32-rs/stm32g4xx-hal/blame/main/src/prelude.rs |
usbalbin
added a commit
that referenced
this pull request
Jan 27, 2025
* Export pac as pac (#156) * rm remaining fdcan files (#160) * defmt format for rcc clocks (#163) * export PwrExt in prelude (#164) * e-hal-v1 (#172) * Implement SpiBus from embedded-hal 1 * i2c: implement embedded-hal traits * gpio: implement embedded-hal 1 digital traits * pwm: implement SetDutyCycle from embedded-hal 1 * delay: temporary DelayNs impl (μs-resolution) * serial: implement embedded-io traits for UART * bump hal-1, remove ToggleableOutputPin impls * remove embedded-hal 0.2 from prelude, rename hals embedded-hal 1.0 renamed from embedded-hal-one to embedded-hal embedded-hal 0.2 renamed from embedded-hal to embedded-hal-old, still re-exported as hal-02 * pwm: use set_duty_cycle_percent in example * run cargo fmt * remove unused dependencies I had added them by accident for an example that didn't end up in the PR * time: fix duration variable names, add doc * docs: fix cargo doc warnings * Try to make syst delay work as before * Cleanup examples --------- Co-authored-by: techmccat <[email protected]> --------- Co-authored-by: AdinAck <[email protected]> Co-authored-by: techmccat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
PwrExtre-export was missing fromprelude.On a side note, why are so many exports commented out? Is this a regression that slipped by?