fix(arduino-cli): avoid wrong status display

Check the overflow has been found to not display succeeded*
while it is not.

Signed-off-by: Frederic Pillon <[email protected]>

Author: fpistm

CI/build/arduino-cli.py

@@ -90,7 +90,7 @@
 
 # error or fatal error
 fork_pattern = re.compile(r"^Error during build: fork/exec")
-error_pattern = re.compile(r":\d+:\d*:?\s.*error:\s|^Error:")
+error_pattern = re.compile(r":\d+:\d*:?\s.*error:\s|^Error:|fatal error:")
 ld_pattern = re.compile("arm-none-eabi/bin/ld:")
 overflow_pattern = re.compile(
     r"(will not fit in |section .+ is not within )?region( .+ overflowed by [\d]+ bytes)?"
@@ -584,6 +584,7 @@ def check_status(status, build_conf, boardKo, nb_build_conf):
         # Check if failed due to a region overflowed
         logFile = build_conf[idx_log] / f"{sketch_name}.log"
         error_found = False
+        overflow_found = False
         for i, line in enumerate(open(logFile)):
             if error_pattern.search(line):
                 error_found = True
@@ -593,17 +594,20 @@ def check_status(status, build_conf, boardKo, nb_build_conf):
                 # If one ld line is not for region overflowed --> failed
                 if overflow_pattern.search(line) is None:
                     error_found = True
+                else:
+                    overflow_found = True
             if error_found:
-                result = ffail
-                boardKo.append(build_conf[idx_b_name])
-                if args.ci:
-                    cat(logFile)
-                nb_build_failed += 1
                 break
-        else:
-            # else consider it succeeded
+        # Succeeded if overflow is found and no other error found
+        if overflow_found and not error_found:
             result = "\033[32msucceeded*\033[0m"
             nb_build_passed += 1
+        else:
+            result = ffail
+            boardKo.append(build_conf[idx_b_name])
+            if args.ci:
+                cat(logFile)
+            nb_build_failed += 1
     else:
         result = "\033[31merror\033[0m"
         boardKo.append(build_conf[idx_b_name])