fix: Assume DNS is the same IP than gateway

ABOSTM · fpistm · commit c191eade0247 · 2022-03-01T17:47:53.000+01:00
When DNS is not provided, it is more likely to be the same than gateway
(more likely than xx.xx.xx.1)

Signed-off-by: Alexandre Bourdiol &lt;alexandre.bourdiol@st.com&gt;
diff --git a/src/STM32Ethernet.cpp b/src/STM32Ethernet.cpp
@@ -33,11 +33,8 @@ void EthernetClass::begin(IPAddress local_ip, IPAddress subnet)
 
 void EthernetClass::begin(IPAddress local_ip, IPAddress subnet, IPAddress gateway)
 {
-  // Assume the DNS server will be the machine on the same network as the local IP
-  // but with last octet being '1'
-  IPAddress dns_server = local_ip;
-  dns_server[3] = 1;
-  begin(local_ip, subnet, gateway, dns_server);
+  // Assume the DNS server will be the same machine than gateway
+  begin(local_ip, subnet, gateway, gateway);
 }
 
 void EthernetClass::begin(IPAddress local_ip, IPAddress subnet, IPAddress gateway, IPAddress dns_server)

Original file line number	Diff line number	Diff line change
`@@ -33,11 +33,8 @@ void EthernetClass::begin(IPAddress local_ip, IPAddress subnet)`
`33`	`33`
`34`	`34`	`void EthernetClass::begin(IPAddress local_ip, IPAddress subnet, IPAddress gateway)`
`35`	`35`	`{`
`36`		`- // Assume the DNS server will be the machine on the same network as the local IP`
`37`		`- // but with last octet being '1'`
`38`		`- IPAddress dns_server = local_ip;`
`39`		`- dns_server[3] = 1;`
`40`		`- begin(local_ip, subnet, gateway, dns_server);`
	`36`	`+ // Assume the DNS server will be the same machine than gateway`
	`37`	`+ begin(local_ip, subnet, gateway, gateway);`
`41`	`38`	`}`
`42`	`39`
`43`	`40`	`void EthernetClass::begin(IPAddress local_ip, IPAddress subnet, IPAddress gateway, IPAddress dns_server)`