Skip to content

Commit 28c426c

Browse files
committed
Cleanup and Grammar 02
1 parent d1039a6 commit 28c426c

21 files changed

+94
-108
lines changed

_faqs/alternatives-are-there-any-missing-features-from-original-jeff-mesnil-stompjs.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ group: Jeff Mesnil's stompjs
44
priority: ZAE
55
---
66

7-
The Jeff Mesnil's stompjs supports STOMP over TCP when used in NodeJS environment.
8-
Other than this, there are no known missing functionality.
7+
Jeff Mesnil's stompjs supports STOMP over TCP when used in the NodeJS environment.
8+
Other than this, there is no known missing functionality.
99
If you intend to use this feature, please raise an issue.
1010

11-
The Jeff Mesnil's stompjs does not support the STOMP protocol strictly
12-
while `@stomp/stompjs` implements the protocol strictly and completely.
11+
Jeff Mesnil's stompjs is not fully compliant to STOMP protocol.
12+
The `@stomp/stompjs` strictly adheres the protocol.
1313
This might, in some cases, give behavioral differences.
14-
If you facing any such issues please raise an issue.
14+
If you are facing any such issues, please raise an issue.

_faqs/alternatives-how-do-i-migrate-from-jeff-mesnil-s-stompjs.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ priority: ZAC
77
Please see [upgrading stompjs](/guide/stompjs/upgrading-stompjs.html)
88
guide.
99

10-
API of v4 of this library is backwards compatible with original stompjs.
11-
In all likelihood your working code would work under compatibility mode of
12-
v5 of this library.
10+
The v4 of this library is backwards compatible with the original stompjs.
11+
In all likelihoods your working code would work under compatibility mode of
12+
v5.
1313

14-
To use newer features like automatic reconnection, 100% compliance with STOMP
14+
To use newer features like automatic reconnection, compliance with STOMP
1515
standards, and binary payloads, you would need to upgrade to newer syntax.

_faqs/alternatives-how-is-it-related-to-stompjs-from-jeff-mesnil.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ priority: ZAA
55
---
66

77
[stompjs](https://www.npmjs.com/package/stompjs)
8-
from [Jeff Mesnil](http://jmesnil.net/) has been the most important
8+
from [Jeff Mesnil](http://jmesnil.net/) has been one of the initial
99
STOMP implementations for JavaScript.
10-
However the original author has no longer been maintaining it since 2016.
10+
However, the original author has no longer been maintaining it since 2016.
1111
`@stomp/stompjs` started as a maintained fork.
1212

1313
`@stomp/stompjs` v4 is an enhanced version of

_faqs/authentication-can-i-use-token-based-authentication-with-these-libraries.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
11
---
2-
question: 'Can I use Token based authentication with these libraries?'
2+
question: 'Can I use Token-based authentication with these libraries?'
33
group: Authentication
44
priority: GAA
55
---
66

77
Even though [WebSocket](https://developer.mozilla.org/en-US/docs/Web/API/WebSocket)
8-
is somewhat similar to HTTP(S), it differs in one very important aspect - it
8+
is somewhat similar to HTTP(S), it differs in one very important aspect it
99
does not allow control of headers.
1010

11-
This poses a limitation on using token based authentication schemes using HTTP headers.
11+
This poses a limitation on using token-based authentication schemes using HTTP headers.
1212

1313
Conventional brokers do not expect any authentication information as part of
1414
HTTP headers or HTTP connection parameters.
1515
These instead rely on STOMP protocol's
1616
[CONNECT Frame](https://stomp.github.io/stomp-specification-1.2.html#CONNECT_or_STOMP_Frame).
17-
This frame can have header key/value pairs.
17+
This frame can have headers as key/value pairs.
1818
You can control these by setting
1919
[connectHeaders](https://stomp-js.github.io/api-docs/latest/classes/Client.html#connectHeaders)
2020
configuration option.
21-
You can pass any pair of strings as key and values.
21+
You can pass any pair of strings as keys and values.
2222

23-
So, typically for token based authentication you will pass the token as part of
23+
So, typically, for token-based authentication you will pass the token as part of
2424
[connectHeaders](https://stomp-js.github.io/api-docs/latest/classes/Client.html#connectHeaders).
2525
Check your broker documentation for details.
2626

_faqs/authentication-my-authentication-tokens-expire-where-should-i-write-code-to-acquire-fresh-tokens.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ The suggested place to acquire fresh tokens is
99
callback.
1010
You can update the
1111
[connectHeaders](https://stomp-js.github.io/api-docs/latest/classes/Client.html#connectHeaders)
12-
after you have acquired fresh token.
12+
after you have acquired a fresh token.
1313

1414
If you need to fetch a token using an async request (say using an XHR),
1515
you can set an async function as the callback.

_faqs/general-can-these-libraries-be-used-with-es6-or-typescript.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@ priority: ACC
66

77
Yes.
88

9-
These libraries are released as [UMD](https://github.com/umdjs/umd).
10-
This should allow these modules to be used as JavaScript on web page as well as
11-
from variety of module systems.
9+
From 2023, these libraries are distributed as Javascript modules as default.
10+
These can be used with `import`.
1211

1312
All these libraries have been developed in TypeScript and type definition
1413
files are included in releases.
1514

16-
In the bundle, ESM5 and ESM6 variants are also included,
17-
which can be used as alternatives.
15+
In addition, a UMD bundle is included to be used as a html script tag.

_faqs/general-how-do-i-enable-logging.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ Please see [enabling debug log](/guide/stompjs/using-stompjs-v5.html#debug).
88

99
The console debug output may have NULL characters, which will prevent it from copying and pasting
1010
into a GitHub issue.
11-
In such cases save it as a text file and attach with the issue.
11+
In such cases, save it as a text file and attach with the issue.

_faqs/general-polyfills-classes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ group: General
44
priority: AKA
55
---
66

7-
Please see [StompJs v5: Polyfills](/guide/stompjs/rx-stomp/ng2-stompjs/pollyfils-for-stompjs-v5.html)
7+
Please see [StompJs v5: Polyfills](/guide/stompjs/rx-stomp/polyfills-for-stompjs.html)

_faqs/general-polyfills-object-assign.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

_faqs/general-tree-shaking.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,4 @@ priority: ADM
66

77
Yes.
88

9-
The versions, `stomp-js@6+` and `rx-stomp@1+` are distributed as `es2015` UMD and modules. These lead to small code size and proper tree shaking behavior.
10-
11-
`rx-stomp`, before v1, was distributed as `commonjs` modules, which may not be tree shaking friendly. Please upgrade if you face issues.
12-
13-
`ng2-stompjs` is likely to cause issues with newer Angular versions. So, please migrate to `rx-stomp`.
9+
Please update the latest versions before reporting any issues related to tree shaking.

0 commit comments

Comments
 (0)