Merge pull request #6 from stone-payments/fix/pbm-backup

Fix pbm backup script

Author: carlos-gonzaga

README.md

@@ -197,6 +197,7 @@ mongodb_backup_script_path: "/etc/mongodb-backup.sh"
 mongodb_backup_log_path: "{{ mongodb_systemlog_path|dirname }}/backup_mongod.log"
 mongodb_backup_path: "{{ mongodb_storage_dbpath }}/backup"     # Local path to mongodump, or PBM path to backups  # Do not use "/" in the end of directories
 mongodb_backup_path_hot_storage : "{{ mongodb_backup_path }}/storage" # Path to storage mongodump backup, or path to PBM Hot Backups when use PBM  # Do not use "/" in the end of directories
+mongodb_backup_store_days: 0   # if the value is 0, the script will not copy the backups to the storage directory, and will keep only one local copy (mongodump).
 mongodb_backup_parameters: "--mongodb-uri \"mongodb://{{ mongodb_backup_user_name }}:{{ mongodb_backup_user_password }}@{{ inventory_hostname }}:{{ mongodb_net_port }}/admin?replicaSet={{ mongodb_replication_replset }}\"" # Mongodump: "--gzip --forceTableScan"
 mongodb_backup_cron_time:
   hour: 3
@@ -210,6 +211,10 @@ mongodb_backup_logrotate: |
     create 644
   }
 
+# PBM Backup
+mongodb_backup_logical_store_days: "{{ mongodb_backup_store_days }}" # Number of days to store pbm logical backups
+mongodb_backup_hot_store_days: "{{ mongodb_backup_store_days }}"     # Number of days to storage hot backups in disk
+
 # Enable PBM Point-in-Time Recovery
 mongodb_backup_pbm_pitr_enable: true
 ```

defaults/main.yml

@@ -156,5 +156,9 @@ mongodb_backup_logrotate: |
     create 644
   }
 
+# PBM Backup
+mongodb_backup_logical_store_days: "{{ mongodb_backup_store_days }}" # Number of days to store pbm logical backups
+mongodb_backup_hot_store_days: "{{ mongodb_backup_store_days }}"     # Number of days to storage hot backups in disk
+
 # Enable PBM Point-in-Time Recovery
 mongodb_backup_pbm_pitr_enable: true

tasks/backup/pbm_configure.yml

@@ -49,11 +49,11 @@
   when: not ansible_check_mode
 
 - name: PBM Config PBM_MONGODB_URI
-  command: pbm config --file /mongodb/pbm_config.yml --mongodb-uri "mongodb://{{ mongodb_backup_user_name }}:{{ mongodb_backup_user_password }}@{{ inventory_hostname }}:{{ mongodb_net_port|default('27017') }}/admin?replicaSet={{ mongodb_replication_replset }}"
+  command: pbm config --file /mongodb/pbm_config.yml --mongodb-uri "mongodb://{{ mongodb_backup_user_name }}:{{ mongodb_backup_user_password }}@{{ inventory_hostname }}:{{ mongodb_net_port }}/admin?replicaSet={{ mongodb_replication_replset }}"
   no_log: true
 
 - name: PBM Enable Point-in-Time Recovery
-  command: pbm config --set pitr.enabled=true --mongodb-uri "mongodb://{{ mongodb_backup_user_name }}:{{ mongodb_backup_user_password }}@{{ inventory_hostname }}:{{ mongodb_net_port|default('27017') }}/admin?replicaSet={{ mongodb_replication_replset }}"
+  command: pbm config --set pitr.enabled=true --mongodb-uri "mongodb://{{ mongodb_backup_user_name }}:{{ mongodb_backup_user_password }}@{{ inventory_hostname }}:{{ mongodb_net_port }}/admin?replicaSet={{ mongodb_replication_replset }}"
   no_log: true
   when: 
     - mongodb_backup_pbm_pitr_enable|bool
@@ -63,8 +63,8 @@
     name: "pbm-agent"
     state: started
 
-- name: Add PBM_MONGODB_URI to bash profile
+- name: Add PBM_MONGODB_URI to bashrc
   lineinfile:
     path: /root/.bashrc
-    line: 'export PBM_MONGODB_URI="mongodb://{{ mongodb_backup_user_name }}:{{ mongodb_backup_user_password }}@{{ inventory_hostname }}:{{ mongodb_net_port|default("27017") }}/admin?replicaSet={{ mongodb_replication_replset }}"'
+    line: 'export PBM_MONGODB_URI="mongodb://{{ mongodb_backup_user_name }}:{{ mongodb_backup_user_password }}@{{ inventory_hostname }}:{{ mongodb_net_port }}/admin?replicaSet={{ mongodb_replication_replset }}"'
   no_log: true

tasks/backup/pbm_remove.yml

@@ -18,7 +18,7 @@
     update_password: on_create
     login_user: "{{ mongodb_root_user_name }}"
     login_password: "{{ mongodb_root_user_password }}"
-    login_port: "{{ mongodb_net_port|default('27017') }}"
+    login_port: "{{ mongodb_net_port }}"
     state: absent
   no_log: true
 
@@ -27,7 +27,7 @@
     mongo --quiet {{ '--ssl' if newrelic_mongodb_ssl == 'true' else '' }} \
       --host {{ inventory_hostname }}  \
       -u {{ mongodb_root_user_name }} -p {{ mongodb_root_user_password }} \
-      --port {{ mongodb_net_port|default('27017') }} \
+      --port {{ mongodb_net_port }} \
       --eval 'db.getSiblingDB("admin").dropRole("pbmAnyAction")'
   ignore_errors: true
   no_log: true
@@ -43,8 +43,9 @@
     state: "absent"
     path: "/etc/sysconfig/pbm-agent"
 
-- name: Remove PBM_MONGODB_URI to bash profile
+- name: Remove PBM_MONGODB_URI to bashrc
   lineinfile:
-    path: /root/.bash_profile
-    line: 'export PBM_MONGODB_URI="mongodb://{{ mongodb_pbm_user_name }}:{{ mongodb_pbm_user_name_password }}@{{ inventory_hostname }}:{{ mongodb_net_port|default("27017") }}/admin?replicaSet={{ mongodb_replication_replset }}"'
+    path: /root/.bashrc
+    line: 'export PBM_MONGODB_URI="mongodb://{{ mongodb_pbm_user_name }}:{{ mongodb_pbm_user_name_password }}@{{ inventory_hostname }}:{{ mongodb_net_port }}/admin?replicaSet={{ mongodb_replication_replset }}"'
     state: absent
+  no_log: true

templates/mongodb.pbpm_backup.sh.j2

@@ -8,13 +8,14 @@ PATH=$PATH:/sbin:/bin:/usr/sbin:/usr/bin
 # MongoDB Script Backup Variables
 BACKUP_LOG_PATH="{{ mongodb_backup_log_path }}"
 BACKUP_PHYSICAL_PATH="{{ mongodb_backup_path_hot_storage  }}"
-BACKUP_STORAGE_DAYS={{ mongodb_backup_store_days }}
+BACKUP_LOGICAL_STORAGE_DAYS={{ mongodb_backup_logical_store_days }}
+BACKUP_HOT_STORAGE_DAYS={{ mongodb_backup_hot_store_days }}
 MONGO_BACKUP_USER="{{ mongodb_backup_user_name }}"
 MONGO_BACKUP_PASSWORD="{{ mongodb_backup_user_password }}"
 MONGO_BACKUP_PARAMETERS="{{ mongodb_backup_parameters }}"
 BACKUP_CURRENT_DATE=$(date +%Y%m%d)
-BACKUP_DELETE_DATE=$(date -d "${BACKUP_STORAGE_DAYS} days ago" "+%Y%m%d")
-BACKUP_PBM_DELETE_DATE=$(date -d "${BACKUP_STORAGE_DAYS} days ago" "+%Y-%m-%d")
+BACKUP_PBM_DELETE_DATE=$(date -d "${BACKUP_LOGICAL_STORAGE_DAYS} days ago" "+%Y-%m-%d")
+BACKUP_HOT_DELETE_DATE=$(date -d "${BACKUP_HOT_STORAGE_DAYS} days ago" "+%Y%m%d")
 
 function print {
     mkdir -p "$(dirname "${BACKUP_LOG_PATH}")"
@@ -48,17 +49,17 @@ if grep -q '"ismaster" : true' /tmp/validate; then
     print "INFO" "Deleting Physical Backups"
 
     # Checks number of backups
-    BACKUP_NB=$(find $BACKUP_PHYSICAL_PATH -type d -name "backup_*" | wc -l)
+    BACKUP_NB=$(find $BACKUP_PHYSICAL_PATH -type f -name "backup_*" | wc -l)
 
     # Delete backups only if the number of existing backups is greater than the desired number of days
     if [[ $BACKUP_NB -gt ${BACKUP_STORAGE_DAYS} ]]
     then
-      find "$BACKUP_PHYSICAL_PATH" -type d -name "backup_*" -printf "%P\n" |
-      while IFS= read -r FOLDER; do
-          FOLDER_BACKUP_DATE=$(echo "${FOLDER}" | awk -F_ '{print $NF}')
-          if [ "${BACKUP_DELETE_DATE}" -gt "${FOLDER_BACKUP_DATE}" ]; then
-              print "INFO" "Deleting backup ${FOLDER}"
-              rm -rf "${BACKUP_PHYSICAL_PATH}/${FOLDER}";
+      find "$BACKUP_PHYSICAL_PATH" -type f -name "backup_*" -printf "%P\n" |
+      while IFS= read -r BACKUP; do
+          BACKUP_DATE=$(echo "${BACKUP}" | awk -F_ '{print $NF}' | cut -f1 -d".")
+          if [ "${BACKUP_HOT_DELETE_DATE}" -gt "${BACKUP_DATE}" ]; then
+              print "INFO" "Deleting backup ${BACKUP}"
+              rm -f "${BACKUP_PHYSICAL_PATH}/${BACKUP}";
           fi
       done
       print "INFO" "Physical Backups deleted"