fix: prevent false-positive item relocation when control items first appear

When control items first appear (e.g., after app restart), the previous
window IDs might be empty or not reflect the actual visible section state.
The code was falling back to checking item identity, which caused items
already in the visible section to be treated as 'new' and incorrectly
relocated.

Fix by only moving items when we have previous window IDs to compare
against - if previousIDs is empty, we can't reliably determine which
items are new to the visible section, so don't move any.

Signed-off-by: Toni Förster <toni.foerster@icloud.com>

Author: stonerl

Thaw/MenuBar/MenuBarItems/MenuBarItemManager.swift

@@ -2688,12 +2688,16 @@ extension MenuBarItemManager {
                 savedSectionForIdentifier[item.uniqueIdentifier] != nil
             guard !hasSavedSection else { return false }
 
-            let isNewIdentity = !knownItemIdentifiers.contains(identifier)
-            let isNewID = previousIDs.isEmpty ? isNewIdentity : !previousIDs.contains(item.windowID)
+            // Only move items that are new to this section (window ID not seen before).
+            // Don't fall back to identity check when previousIDs is empty - that causes
+            // false positives where items already in visible section get moved.
+            let isNewID = !previousIDs.isEmpty && !previousIDs.contains(item.windowID)
+            guard isNewID else { return false }
+
             let notPlacedHidden = !hiddenTags.contains(item.tag) && !alwaysHiddenTags.contains(item.tag)
             let bundle = bundleID(for: item)
             let notPinnedHidden = bundle.map { !pinnedHiddenBundleIDs.contains($0) && !pinnedAlwaysHiddenBundleIDs.contains($0) } ?? true
-            return notPlacedHidden && notPinnedHidden && (isNewID || isNewIdentity)
+            return notPlacedHidden && notPinnedHidden
         }
         guard let candidate else {
             if !leftmostItems.isEmpty && savedSectionForIdentifier.isEmpty == false {