fix: export effects from receipt (#81)

They were not being exported at all 😢

Author: alanshaw

core/receipt/receipt.go

@@ -247,6 +247,16 @@ func (r *receipt[O, X]) Export() iter.Seq2[block.Block, error] {
 		iterators = append(iterators, inv.Export())
 	}
 
+	for _, f := range r.Fx().Fork() {
+		if inv, ok := f.Invocation(); ok {
+			iterators = append(iterators, inv.Export())
+		}
+	}
+
+	if inv, ok := r.Fx().Join().Invocation(); ok {
+		iterators = append(iterators, inv.Export())
+	}
+
 	for _, prf := range r.Proofs() {
 		if delegation, ok := prf.Delegation(); ok {
 			iterators = append(iterators, delegation.Export())
@@ -458,12 +468,6 @@ func Issue[O, X ipld.Builder](issuer ucan.Signer, out result.Result[O, X], ran r
 		return nil, err
 	}
 
-	// copy proof blocks into store
-	prooflinks, err := cfg.prf.WriteInto(bs)
-	if err != nil {
-		return nil, err
-	}
-
 	var forks []ipld.Link
 	for _, effect := range cfg.forks {
 		if inv, ok := effect.Invocation(); ok {
@@ -485,6 +489,12 @@ func Issue[O, X ipld.Builder](issuer ucan.Signer, out result.Result[O, X], ran r
 		Join: join,
 	}
 
+	// copy proof blocks into store
+	prooflinks, err := cfg.prf.WriteInto(bs)
+	if err != nil {
+		return nil, err
+	}
+
 	metaModel := rdm.MetaModel{}
 	// attempt to convert meta into IPLD format if present.
 	if cfg.meta != nil {

core/receipt/receipt_test.go

@@ -286,12 +286,34 @@ func TestExport(t *testing.T) {
 	)
 	require.NoError(t, err)
 
+	forkFx := fx.FromInvocation(
+		helpers.Must(
+			invocation.Invoke(
+				fixtures.Alice,
+				fixtures.Bob,
+				ucan.NewCapability("test/fx/fork", fixtures.Alice.DID().String(), ucan.NoCaveats{}),
+			),
+		),
+	)
+
+	joinFx := fx.FromInvocation(
+		helpers.Must(
+			invocation.Invoke(
+				fixtures.Alice,
+				fixtures.Bob,
+				ucan.NewCapability("test/fx/join", fixtures.Alice.DID().String(), ucan.NoCaveats{}),
+			),
+		),
+	)
+
 	ran := ran.FromInvocation(inv)
 	ok := someOkType{SomeOkProperty: "some ok value"}
 	rcpt, err := Issue(
 		fixtures.Alice,
 		result.Ok[someOkType, someErrorType](ok),
 		ran,
+		WithFork(forkFx, fx.FromLink(helpers.RandomCID())),
+		WithJoin(joinFx),
 		WithProofs(delegation.Proofs{
 			delegation.FromDelegation(prf),
 			// include an absent proof to prove things don't break - PUN INTENDED
@@ -309,7 +331,7 @@ func TestExport(t *testing.T) {
 		require.NoError(t, bs.Put(b))
 		blks = append(blks, b)
 	}
-	require.Len(t, blks, 3)
+	require.Len(t, blks, 5)
 	require.True(t, slices.ContainsFunc(blks, func(b ipld.Block) bool {
 		return b.Link().String() == prf.Link().String()
 	}))