Merge pull request #1125 from vojtechtrefny/master_lvcreate-empty-pvs-fix

lvm-dbus: Fix calling lvcreate with empty list of PVs

Author: vojtechtrefny

src/plugins/lvm/lvm-dbus.c

@@ -2343,7 +2343,7 @@ gboolean bd_lvm_lvcreate (const gchar *vg_name, const gchar *lv_name, guint64 si
     GVariant *extra_params = NULL;
 
     /* build the array of PVs (object paths) */
-    if (pv_list) {
+    if (pv_list && *pv_list) {
         g_variant_builder_init (&builder, G_VARIANT_TYPE_ARRAY);
         for (pv=pv_list; *pv; pv++) {
             path = get_object_path (*pv, error);

tests/_lvm_cases.py

@@ -881,6 +881,13 @@ def test_lvcreate_lvremove(self):
         succ = BlockDev.lvm_lvremove("testVG", "testLV", True, None)
         self.assertTrue(succ)
 
+        # no PVs specified
+        succ = BlockDev.lvm_lvcreate("testVG", "testLV", 512 * 1024**2, None, [], None)
+        self.assertTrue(succ)
+
+        succ = BlockDev.lvm_lvremove("testVG", "testLV", True, None)
+        self.assertTrue(succ)
+
         # not enough space (only one PV)
         with self.assertRaisesRegex(GLib.GError, "Insufficient free space"):
             succ = BlockDev.lvm_lvcreate("testVG", "testLV", 1048 * 1024**2, None, [self.loop_dev], None)