Move common LVM code to a separate file #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of functions are the same in both CLI and DBus plugin.
Some of the tests recompile the plugin, we need to change some paths for the tests to work.
tbzatek
approved these changes
May 28, 2025
| #define LVM_MIN_VERSION "2.02.116" | ||
| #define LVM_VERSION_FSRESIZE "2.03.19" | ||
|
|
||
| extern GMutex global_config_lock; |
Member
There was a problem hiding this comment.
have you considered switching to G_LOCK_DEFINE() and static locks? G_LOCK() or G_LOCK_EXTERN()? I think GMutex is more suited for dynamic allocations.
Member
Author
There was a problem hiding this comment.
Lets keep this simple and I'll take a look at the locks and deal with them in a separate PR.
vojtechtrefny
merged commit ae6e249
into
storaged-project:master
45 of 46 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly reduces code duplication between the CLI and DBus plugin.