tests: Fix SCSI debug disks cleanup in SMART tests #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple fixes including avoiding infinite loops in cleanup, retries for the module unloading and moving common code for the two plugin implementation tests to utils.
vojtechtrefny
force-pushed
the
master_smart-test-iscsi-fix
branch
from
3840c90 to
42ae4db
Compare
Member
Author
|
Reworked version with some more fixes and cleanup, CI seems to be happy with this one so marking as ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally one of the issues found by pylint and part of #1119 but for some reason fixing this causes an infinite loop in
_setup_scsi_debugon Debian and CentOS (but not Fedora). We need some more time to investigate this and it's out of scope for the tests speed up so I am keeping this as a draft for now.