Skip to content

Commit eee2eb2

Browse files
committed
fix(monorepo): Remove implicit dependencies from the internal Nx plugins
1 parent 65bb5cc commit eee2eb2

File tree

3 files changed

+10
-17
lines changed

3 files changed

+10
-17
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ The **⚡Storm Stack** monorepo contains the [storm-stack](https://www.npmjs.com
4747
- [Running End-to-End Tests](#running-end-to-end-tests)
4848
- [Understand your workspace](#understand-your-workspace)
4949
- [☁ Nx Cloud](#-nx-cloud)
50-
- [Distributed Computation Caching \& Distributed Task Execution](#distributed-computation-caching--distributed-task-execution)
50+
- [Distributed Computation Caching & Distributed Task Execution](#distributed-computation-caching--distributed-task-execution)
5151
- [Roadmap](#roadmap)
5252
- [Contributing](#contributing)
5353
- [Support](#support)

tools/nx/src/plugins/adapter.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -170,22 +170,21 @@ export const createNodesV2: CreateNodesV2<StormStackAdapterPluginOptions> = [
170170
setDefaultProjectTags(project, name);
171171
addProjectScopeTag(project, StormStackProjectTagScopeValue.ADAPTER);
172172

173-
const implicitDependencies = project.implicitDependencies ?? [];
174-
if (!implicitDependencies.includes("storm-stack")) {
175-
implicitDependencies.push("storm-stack");
176-
}
177-
if (!implicitDependencies.includes("plugin-node")) {
178-
implicitDependencies.push("plugin-node");
179-
}
173+
// const implicitDependencies = project.implicitDependencies ?? [];
174+
// if (!implicitDependencies.includes("storm-stack")) {
175+
// implicitDependencies.push("storm-stack");
176+
// }
177+
// if (!implicitDependencies.includes("plugin-node")) {
178+
// implicitDependencies.push("plugin-node");
179+
// }
180180

181181
const result = project?.name
182182
? {
183183
projects: {
184184
[project.name]: {
185185
...project,
186186
root: relativeRoot,
187-
targets,
188-
implicitDependencies
187+
targets
189188
}
190189
}
191190
}

tools/nx/src/plugins/plugin.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -149,19 +149,13 @@ export const createNodesV2: CreateNodesV2<StormStackPluginPluginOptions> = [
149149
);
150150
addProjectScopeTag(project, StormStackProjectTagScopeValue.PLUGIN);
151151

152-
const implicitDependencies = project.implicitDependencies ?? [];
153-
if (!implicitDependencies.includes("storm-stack")) {
154-
implicitDependencies.push("storm-stack");
155-
}
156-
157152
const result = project?.name
158153
? {
159154
projects: {
160155
[project.name]: {
161156
...project,
162157
root: relativeRoot,
163-
targets,
164-
implicitDependencies
158+
targets
165159
}
166160
}
167161
}

0 commit comments

Comments
 (0)