Support basic authentication via HTTPS (#55)

Author: stormcat24

README.md

@@ -84,6 +84,23 @@ Even if protodep.lock exists, you can force update dependenies.
 $ protodep up -f
 ```
 
+### Getting via HTTPS
+
+If you want to get it via HTTPS, do as follows.
+
+```bash
+$ protodep up --use-https
+```
+
+And also, if Basic authentication is required, do as follows.
+If you have 2FA enabled, specify the Personal Access Token as the password. 
+
+```bash
+$ protodep up --use-https \
+    --basic-auth-username=your-github-username \
+    --basic-auth-password=your-github-password
+```
+
 License
 ===
 See [LICENSE](LICENSE).

cmd/up.go

@@ -58,6 +58,22 @@ var upCmd = &cobra.Command{
 		}
 		logger.Info("use https = %t", useHttps)
 
+		basicAuthUsername, err := cmd.Flags().GetString("basic-auth-username")
+		if err != nil {
+			return err
+		}
+		if basicAuthUsername != "" {
+			logger.Info("https basic auth username = %s", basicAuthUsername)
+		}
+
+		basicAuthPassword, err := cmd.Flags().GetString("basic-auth-password")
+		if err != nil {
+			return err
+		}
+		if basicAuthPassword != "" {
+			logger.Info("https basic auth username = %s", strings.Repeat("x", len(basicAuthPassword))) // Do not display the password.
+		}
+
 		pwd, err := os.Getwd()
 		if err != nil {
 			return err
@@ -69,7 +85,7 @@ var upCmd = &cobra.Command{
 		}
 
 		if useHttps {
-			authProvider = helper.NewAuthProvider(helper.WithHTTPS())
+			authProvider = helper.NewAuthProvider(helper.WithHTTPS(basicAuthUsername, basicAuthPassword))
 		} else {
 			if identityFile == "" && password == "" {
 				authProvider = helper.NewAuthProvider()
@@ -98,4 +114,6 @@ func initDepCmd() {
 	upCmd.PersistentFlags().StringP("password", "p", "", "set the password for SSH")
 	upCmd.PersistentFlags().BoolP("cleanup", "c", false, "cleanup cache before exec.")
 	upCmd.PersistentFlags().BoolP("use-https", "u", false, "use HTTPS to get dependencies.")
+	upCmd.PersistentFlags().StringP("basic-auth-username", "", "", "set the username with Basic Auth via HTTPS")
+	upCmd.PersistentFlags().StringP("basic-auth-password", "", "", "set the password or personal access token(when enabled 2FA) with Basic Auth via HTTPS")
 }

helper/auth.go

@@ -2,22 +2,24 @@ package helper
 
 import (
 	"fmt"
+	"gopkg.in/src-d/go-git.v4/plumbing/transport/http"
 
 	"gopkg.in/src-d/go-git.v4/plumbing/transport"
 	"gopkg.in/src-d/go-git.v4/plumbing/transport/ssh"
 )
 
 type authMethod string
 
-const(
+const (
 	SSHAgent authMethod = "SSHAgent"
-	SSH = "SSH"
-	HTTPS = "HTTPS"
+	SSH                 = "SSH"
+	HTTPS               = "HTTPS"
 )
 
 type authOptions struct {
-	method authMethod
-	pemFile string
+	method   authMethod
+	pemFile  string
+	username string
 	password string
 }
 
@@ -29,7 +31,6 @@ func (fao *funcAuthOption) apply(do *authOptions) {
 	fao.f(do)
 }
 
-
 type AuthOption interface {
 	apply(*authOptions)
 }
@@ -48,12 +49,16 @@ type AuthProviderWithSSHAgent struct {
 }
 
 type AuthProviderHTTPS struct {
+	username string
+	password string
 }
 
-func WithHTTPS() AuthOption {
+func WithHTTPS(username, password string) AuthOption {
 	return &funcAuthOption{
 		f: func(options *authOptions) {
 			options.method = HTTPS
+			options.username = username
+			options.password = password
 		},
 	}
 }
@@ -85,7 +90,10 @@ func NewAuthProvider(opt ...AuthOption) AuthProvider {
 			password: opts.password,
 		}
 	} else {
-		authProvider = &AuthProviderHTTPS{}
+		authProvider = &AuthProviderHTTPS{
+			username: opts.username,
+			password: opts.password,
+		}
 	}
 
 	return authProvider
@@ -128,6 +136,11 @@ func (p *AuthProviderHTTPS) GetRepositoryURL(reponame string) string {
 }
 
 func (p *AuthProviderHTTPS) AuthMethod() (transport.AuthMethod, error) {
-	// nil is ok.
-	return nil, nil
+	if p.username == "" && p.password == "" {
+		return nil, nil
+	}
+	return &http.BasicAuth{
+		Username: p.username,
+		Password: p.password,
+	}, nil
 }