1212 Fix test due to an IAM bugfix.

Author: josebarrueta

extensions/httpclient/src/test/groovy/com/stormpath/sdk/client/ClientIT.groovy

@@ -39,8 +39,7 @@ import org.testng.annotations.BeforeClass
 import org.testng.annotations.BeforeTest
 
 import static com.stormpath.sdk.application.Applications.newCreateRequestFor
-import static org.testng.Assert.assertEquals
-import static org.testng.Assert.assertTrue
+import static org.testng.Assert.*
 
 abstract class ClientIT {
 
@@ -167,28 +166,22 @@ abstract class ClientIT {
     }
 
     protected void getDeletedResourceError(String href, Class resourceClass){
-        Throwable e = null;
         try {
             client.getResource(href, resourceClass)
+            fail("should have thrown ResourceException")
         } catch (ResourceException re) {
-            e = re
             assertEquals(re.status, 404)
             assertEquals(re.getCode(), 404)
         }
-
-        assertTrue(e instanceof ResourceException)
     }
 
-    protected void updatedSaveableError(Saveable input, int expectedErrorCode){
-        Throwable e = null;
+    static void updatedSaveableError(Saveable input, int expectedErrorCode) {
         try {
             input.save()
+            fail("should have thrown ResourceException")
         } catch (ResourceException re) {
-            e = re
             assertEquals(re.status, 400)
             assertEquals(re.getCode(), expectedErrorCode)
         }
-
-        assertTrue(e instanceof ResourceException)
     }
 }

extensions/httpclient/src/test/groovy/com/stormpath/sdk/impl/saml/RegisteredSamlServiceProviderIT.groovy

@@ -72,6 +72,16 @@ class RegisteredSamlServiceProviderIT extends AbstractSamlIT {
 
     @Test
     void testUniquenessOfRegisteredSamlServiceProviders() {
+        def registeredSamlServiceProvider = createRegisteredSamlServiceProvider()
+
+        def registeredSamlServiceProvider2 = createRegisteredSamlServiceProvider()
+
+        registeredSamlServiceProvider.setEntityId(registeredSamlServiceProvider2.getEntityId())
+
+        updatedSaveableError(registeredSamlServiceProvider, 10110)
+    }
+
+    RegisteredSamlServiceProvider createRegisteredSamlServiceProvider() {
         def registeredSamlServiceProvider = client.instantiate(RegisteredSamlServiceProvider)
         registeredSamlServiceProvider
                 .setName("testName")
@@ -83,8 +93,7 @@ class RegisteredSamlServiceProviderIT extends AbstractSamlIT {
 
         assertRegisteredSAMLServiceProviderFields(registeredSamlServiceProviderReturned, registeredSamlServiceProvider)
 
-        registeredSamlServiceProvider.setEntityId(registeredSamlServiceProvider.getEntityId())
-        updatedSaveableError(registeredSamlServiceProvider, 10110)
+        return registeredSamlServiceProviderReturned
     }
 
     @Test