Merge pull request #26 from houdaslassi/feature/refactors-enhancements

fix: skip counting released jobs as processed

Author: houdaslassi

src/Listeners/RecordJobSuccess.php

@@ -23,6 +23,22 @@ public function handle(JobProcessed $event): void
             return;
         }
 
+        // Some jobs (like rate-limited ones) are "processed" only to be released immediately.
+        // Laravel exposes helpers to detect this so we don't count them as successful runs.
+        if (method_exists($event->job, 'isReleased') && $event->job->isReleased()) {
+            VantageLogger::debug('Queue Monitor: Job was released, skipping processed record', [
+                'job_class' => $this->jobClass($event),
+            ]);
+            return;
+        }
+
+        if (method_exists($event->job, 'isDeletedOrReleased') && $event->job->isDeletedOrReleased()) {
+            VantageLogger::debug('Queue Monitor: Job was deleted or released, skipping processed record', [
+                'job_class' => $this->jobClass($event),
+            ]);
+            return;
+        }
+
         $uuid = $this->bestUuid($event);
         $jobClass = $this->jobClass($event);
         $queue = $event->job->getQueue();

tests/Feature/RateLimitedJobTest.php

@@ -0,0 +1,52 @@
+<?php
+
+use HoudaSlassi\Vantage\Listeners\RecordJobSuccess;
+use HoudaSlassi\Vantage\Models\VantageJob;
+use Illuminate\Queue\Events\JobProcessed;
+
+it('skips counting released jobs as processed', function () {
+    VantageJob::query()->delete();
+
+    $releasedJob = new class {
+        public function getQueue() { return 'default'; }
+        public function attempts() { return 1; }
+        public function uuid() { return 'released-uuid'; }
+        public function resolveName() { return 'App\\Jobs\\RateLimitedJob'; }
+        public function isReleased() { return true; }
+        public function isDeletedOrReleased() { return true; }
+    };
+
+    $event = new JobProcessed('database', $releasedJob);
+    (new RecordJobSuccess())->handle($event);
+
+    expect(VantageJob::where('uuid', 'released-uuid')->exists())->toBeFalse();
+});
+
+it('still counts normal processed jobs', function () {
+    VantageJob::query()->delete();
+
+    $record = VantageJob::create([
+        'uuid' => 'normal-uuid',
+        'job_class' => 'App\\Jobs\\NormalJob',
+        'status' => 'processing',
+        'started_at' => now()->subSecond(),
+    ]);
+
+    $normalJob = new class {
+        public function getQueue() { return 'default'; }
+        public function attempts() { return 1; }
+        public function uuid() { return 'normal-uuid'; }
+        public function resolveName() { return 'App\\Jobs\\NormalJob'; }
+        public function isReleased() { return false; }
+        public function isDeletedOrReleased() { return false; }
+    };
+
+    $event = new JobProcessed('database', $normalJob);
+    (new RecordJobSuccess())->handle($event);
+
+    $updated = VantageJob::find($record->id);
+
+    expect($updated->status)->toBe('processed')
+        ->and($updated->finished_at)->not()->toBeNull();
+});
+