Skip to content

Commit 77e0809

Browse files
feat: apply suggestions from code review by Demetrius
Co-authored-by: Demetrius Feijóo <[email protected]>
1 parent 6dbc637 commit 77e0809

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

packages/field-plugin/src/messaging/pluginMessage/containerToPluginMessage/LoadedMessage.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ describe('LoadedMessage', () => {
173173
}),
174174
).toEqual(true)
175175
})
176-
it('is false', () => {
176+
it('is a boolean and it is false', () => {
177177
expect(
178178
isLoadedMessage({
179179
...stub,

packages/field-plugin/src/messaging/pluginMessage/containerToPluginMessage/StateChangedMessage.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ describe('StateChangedMessage', () => {
173173
}),
174174
).toEqual(true)
175175
})
176-
it('is false', () => {
176+
it('is a boolean and it is false', () => {
177177
expect(
178178
isStateMessage({
179179
...stub,

packages/field-plugin/src/messaging/pluginMessage/pluginToContainerMessage/GetUserContextMessage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { isMessageToContainer, MessageToContainer } from './MessageToContainer'
33
export type GetUserContextMessage = MessageToContainer<'getUserContext'> & {
44
// Previously, debounced message was the default behavior.
55
// That debouncing implementation can be problematic, for example,
6-
// when multiple field plugin instances request for context.
6+
// when multiple field plugin instances request for user context.
77
debounce: false
88
}
99

packages/sandbox/src/components/FieldPluginSandbox.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,11 +269,12 @@ const useSandbox = (
269269
)
270270

271271
const onUserContextRequested = useCallback(
272-
() =>
272+
(message: GetUserContextMessage) =>
273273
dispatchUserContextRequest({
274274
uid,
275275
action: 'get-user-context',
276276
user,
277+
callbackId: message.callbackId,
277278
}),
278279
[uid, dispatchUserContextRequest, user],
279280
)

0 commit comments

Comments
 (0)