clean up test cases

Author: eunjae-lee

packages/field-plugin/src/createFieldPlugin/createPluginActions/createPluginActions.test.ts

@@ -5,6 +5,7 @@ import {
   ModalChangeMessage,
   ValueChangeMessage,
 } from '../../messaging'
+import { emptyAsset } from '../../messaging/pluginMessage/containerToPluginMessage/Asset.test'
 
 // INFO: The methods like `setContent` is not being resolved in this file because `pushCallback` doesn't resolve.
 // We can also mock `callbackQueue` and make it resolve, and resolve this `no-floating-promises` issue.
@@ -231,33 +232,10 @@ describe('createPluginActions', () => {
         field: 'dummy',
         callbackId: TEST_CALLBACK_ID,
         filename,
-        asset: {
-          id: 0,
-          fieldtype: 'asset',
-          name: '',
-          filename: '',
-          meta_data: {},
-          title: '',
-          copyright: '',
-          focus: '',
-          alt: '',
-          source: '',
-          is_private: false,
-        },
+        asset: emptyAsset,
       })
       const result = await promise
-      expect(result).toEqual({
-        filename,
-        fieldtype: 'asset',
-        name: '',
-        meta_data: {},
-        title: '',
-        copyright: '',
-        focus: '',
-        alt: '',
-        source: '',
-        is_private: false,
-      })
+      expect(result).toEqual(emptyAsset)
     })
     it('does not call the callack function when callbackId does not match', async () => {
       const WRONG_CALLBACK_ID = TEST_CALLBACK_ID + '_wrong'
@@ -279,19 +257,7 @@ describe('createPluginActions', () => {
         field: 'dummy',
         callbackId: WRONG_CALLBACK_ID,
         filename,
-        asset: {
-          id: 0,
-          fieldtype: 'asset',
-          name: '',
-          filename: '',
-          meta_data: {},
-          title: '',
-          copyright: '',
-          focus: '',
-          alt: '',
-          source: '',
-          is_private: false,
-        },
+        asset: emptyAsset,
       })
       const resolvedFn = jest.fn()
       const rejectedFn = jest.fn()

packages/field-plugin/src/createFieldPlugin/createPluginActions/createPluginMessageListener/handlePluginMessage.test.ts

@@ -6,6 +6,7 @@ import {
   LoadedMessage,
   MessageToPlugin,
 } from '../../../messaging'
+import { emptyAsset } from '../../../messaging/pluginMessage/containerToPluginMessage/Asset.test'
 
 const uid = 'abc123'
 const mockCallbacks = (): PluginMessageCallbacks => ({
@@ -95,19 +96,7 @@ describe('handlePluginMessage', () => {
       filename: '/my-file.jpg',
       field: 'callback-uid',
       callbackId: 'test-callback-id',
-      asset: {
-        id: 0,
-        fieldtype: 'asset',
-        name: '',
-        filename: '',
-        meta_data: {},
-        title: '',
-        copyright: '',
-        focus: '',
-        alt: '',
-        source: '',
-        is_private: false,
-      },
+      asset: emptyAsset,
     }
     const callbacks = mockCallbacks()
     handlePluginMessage(data, uid, callbacks)

packages/field-plugin/src/messaging/pluginMessage/containerToPluginMessage/Asset.test.ts

@@ -1,21 +1,28 @@
-import { AssetWrapper, assetFromAssetSelectedMessage, isAsset } from './Asset'
+import {
+  Asset,
+  AssetWrapper,
+  assetFromAssetSelectedMessage,
+  isAsset,
+} from './Asset'
 import { AssetSelectedMessage } from './AssetSelectedMessage'
 
+export const emptyAsset: Asset = {
+  id: 0,
+  fieldtype: 'asset',
+  name: '',
+  filename: '',
+  meta_data: {},
+  title: '',
+  copyright: '',
+  focus: '',
+  alt: '',
+  source: '',
+  is_private: false,
+}
+
 const stub: AssetWrapper = {
   filename: 'https://somthing.com/myimage.jpg',
-  asset: {
-    id: 0,
-    fieldtype: 'asset',
-    name: '',
-    filename: '',
-    meta_data: {},
-    title: '',
-    copyright: '',
-    focus: '',
-    alt: '',
-    source: '',
-    is_private: false,
-  },
+  asset: emptyAsset,
 }
 
 const assetSelectedMessage: AssetSelectedMessage = {
@@ -24,19 +31,7 @@ const assetSelectedMessage: AssetSelectedMessage = {
   callbackId: 'test-callback-id',
   action: 'asset-selected',
   filename: 'https://somthing.com/myimage.jpg',
-  asset: {
-    id: 0,
-    fieldtype: 'asset',
-    name: '',
-    filename: '',
-    meta_data: {},
-    title: '',
-    copyright: '',
-    focus: '',
-    alt: '',
-    source: '',
-    is_private: false,
-  },
+  asset: emptyAsset,
 }
 
 describe('Asset', function () {
@@ -61,24 +56,8 @@ describe('Asset', function () {
         assetFromAssetSelectedMessage(assetSelectedMessage),
       ).toHaveProperty('filename')
     })
-    it('keeps unknown properties', () => {
-      expect(
-        assetFromAssetSelectedMessage({
-          ...assetSelectedMessage,
-          unknownProperty: 'any-value',
-        }),
-      ).toHaveProperty('unknownProperty', 'any-value')
-    })
   })
   describe('validation', () => {
-    it('allows unknown properties', () => {
-      expect(
-        isAsset({
-          ...stub,
-          anUnknownProperty: 'something',
-        }),
-      ).toEqual(true)
-    })
     describe('the filename property', () => {
       it('is required', () => {
         expect(

packages/field-plugin/src/messaging/pluginMessage/containerToPluginMessage/AssetSelectedMessage.test.ts

@@ -3,26 +3,15 @@ import {
   isAssetSelectedMessage,
 } from './AssetSelectedMessage'
 import { isAsset } from './Asset'
+import { emptyAsset } from './Asset.test'
 
 const stub: AssetSelectedMessage = {
   action: 'asset-selected',
   uid: '-preview',
   field: 'dummy-field',
   callbackId: 'test-callback-id',
   filename: 'https://somthing.com/myimage.jpg',
-  asset: {
-    id: 0,
-    fieldtype: 'asset',
-    name: '',
-    filename: '',
-    meta_data: {},
-    title: '',
-    copyright: '',
-    focus: '',
-    alt: '',
-    source: '',
-    is_private: false,
-  },
+  asset: emptyAsset,
 }
 
 describe('AssetSelectedMessage', function () {
@@ -32,14 +21,6 @@ describe('AssetSelectedMessage', function () {
   it('is an Asset', () => {
     expect(isAsset(stub)).toEqual(true)
   })
-  it('allows unknown properties', () => {
-    expect(
-      isAssetSelectedMessage({
-        ...stub,
-        anUnknownProperty: 'something',
-      }),
-    ).toEqual(true)
-  })
   describe('the action property', () => {
     it('equals "asset-selected"', () => {
       expect(
@@ -58,13 +39,8 @@ describe('AssetSelectedMessage', function () {
   })
   describe('the field property', () => {
     it('is optional', () => {
-      expect(
-        isAssetSelectedMessage({
-          action: 'asset-selected',
-          uid: '-preview',
-          filename: 'https://somthing.com/myimage.jpg',
-        }),
-      ).toEqual(true)
+      const { field: _field, ...withoutField } = stub
+      expect(isAssetSelectedMessage(withoutField)).toEqual(true)
     })
     it('can be undefined', () => {
       expect(