Skip to content

Commit b0a3d52

Browse files
committed
chore(deps): add .nvmrc to latest node and docs on localhost demo development
1 parent de13e81 commit b0a3d52

File tree

7 files changed

+8
-10
lines changed

7 files changed

+8
-10
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ yarn test:lib
8080
To test the library with a demo, you need to run three commands in parallel:
8181

8282
- `yarn dev:lib`: Watches file changes in the library and updates the bundle output.
83-
- `yarn dev:demo`: Runs the demo Field Plugin located at `packages/demo`. Update it to test changes to the library.
83+
- `yarn dev:demo`: Runs the demo Field Plugin located at `packages/demo`. Update it to test changes to the library. Uncomment `targetOrigin` at `packages/demo/src/components/FieldPluginDemo.tsx`.
8484
- `yarn dev:sandbox`: Runs the Sandbox locally.
8585

8686
Run all the commands in three separate terminals, then open the Sandbox at `http://localhost:7070/`. This Container hosts the demo Field Plugin. Whenever you change a file in the library, the bundle output updates automatically and the demo app does Hot-Module Replacement (HMR). You can then seamlessly test it in the running Sandbox application.

packages/cli/templates/js/.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18.16.0
1+
22.14.0
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18.16.0
1+
22.14.0

packages/cli/templates/react/.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18.16.0
1+
22.14.0

packages/cli/templates/vue2/.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18.16.0
1+
22.14.0

packages/cli/templates/vue3/.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18.16.0
1+
22.14.0

packages/demo/src/components/FieldPluginDemo.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ export const FieldPluginDemo: FunctionComponent = () => {
2020
const { type, data, actions } = useFieldPlugin({
2121
validateContent,
2222
enablePortalModal: true,
23+
// targetOrigin: 'http://localhost:7070', // Uncomment for local development
2324
})
2425

2526
if (type === 'loading') {
@@ -39,10 +40,7 @@ export const FieldPluginDemo: FunctionComponent = () => {
3940
)
4041
}
4142

42-
const props = {
43-
data,
44-
actions,
45-
}
43+
const props = { data, actions }
4644

4745
return props.data.isModalOpen ? (
4846
<ModalView {...props} />

0 commit comments

Comments
 (0)