feat(helper): remove comment and adjust check for when manifest is not defined to remove it from query params

BibiSebi · BibiSebi · commit e50aff198a14 · 2024-09-18T15:49:06.000+02:00
diff --git a/packages/field-plugin/helpers/vite/src/sandbox.ts b/packages/field-plugin/helpers/vite/src/sandbox.ts
@@ -20,7 +20,7 @@ export const buildQueryString = (params: SandboxQueryParams) => {
     url: params.url,
   }
 
-  if (params.manifest !== null) {
+  if (params.manifest !== undefined) {
     queryParams.manifest = JSON.stringify(params.manifest)
   }
 
diff --git a/packages/manifest-helper/src/manifest.ts b/packages/manifest-helper/src/manifest.ts
@@ -64,7 +64,6 @@ const validateSchema = (manifest: Manifest): void => {
   validateOptions(manifest.options)
 }
 
-//NOTE: There is a duplicate of this function in the field-plugin/helpers/vite/src/manifest.ts file
 const validateOptions = (options: unknown[]): void => {
   const incorrectValues: string[] = []
 

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ export const buildQueryString = (params: SandboxQueryParams) => {`
`20`	`20`	`url: params.url,`
`21`	`21`	`}`
`22`	`22`
`23`		`- if (params.manifest !== null) {`
	`23`	`+ if (params.manifest !== undefined) {`
`24`	`24`	`queryParams.manifest = JSON.stringify(params.manifest)`
`25`	`25`	`}`
`26`	`26`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,6 @@ const validateSchema = (manifest: Manifest): void => {`
`64`	`64`	`validateOptions(manifest.options)`
`65`	`65`	`}`
`66`	`66`
`67`		`-//NOTE: There is a duplicate of this function in the field-plugin/helpers/vite/src/manifest.ts file`
`68`	`67`	`const validateOptions = (options: unknown[]): void => {`
`69`	`68`	`const incorrectValues: string[] = []`
`70`	`69`