fix: is_external_url is now optional (#48)

Author: silasjoisten

src/Domain/Type/Asset.php

@@ -52,8 +52,13 @@ public function __construct(array $values)
         Assert::keyExists($values, 'filename');
         $this->url = TrimmedNonEmptyString::fromString($values['filename'])->toString();
 
-        Assert::keyExists($values, 'is_external_url');
-        $this->isExternalUrl = true === $values['is_external_url'];
+        $isExternalUrl = false;
+
+        if (\array_key_exists('is_external_url', $values)) {
+            $isExternalUrl = true === $values['is_external_url'];
+        }
+
+        $this->isExternalUrl = $isExternalUrl;
 
         $alt = null;
 

src/Domain/Type/Editable.php

@@ -20,7 +20,6 @@
 use Webmozart\Assert\Assert;
 use function Safe\json_decode;
 use function Safe\json_encode;
-use function Symfony\Component\String\u;
 
 /**
  * @experimental This class is experimental and may change in future versions.

src/Domain/Type/MultiLink.php

@@ -20,7 +20,7 @@
 
 /**
  * @experimental This class is experimental and may change in future versions.
- * 
+ *
  * @author Silas Joisten <[email protected]>
  */
 final readonly class MultiLink

tests/Unit/Domain/Type/AssetTest.php

@@ -308,4 +308,24 @@ public static function orientationProvider(): iterable
         yield 'landscape' => [Orientation::Landscape, 1920, 1080];
         yield 'portrait' => [Orientation::Portrait, 1080, 1920];
     }
+
+    #[Test]
+    public function isExternalUrl(): void
+    {
+        $faker = self::faker();
+        $response = $faker->storyAssetResponse([
+            'is_external_url' => $expected = $faker->boolean(),
+        ]);
+
+        self::assertSame($expected, (new Asset($response))->isExternalUrl);
+    }
+
+    #[Test]
+    public function isExternalUrlKeyIsOptional(): void
+    {
+        $response = self::faker()->storyAssetResponse();
+        unset($response['is_external_url']);
+
+        self::assertFalse((new Asset($response))->isExternalUrl);
+    }
 }