chore: add exception message for invalid path value
#68
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
=========================================
Coverage 93.88% 93.88%
- Complexity 461 462 +1
=========================================
Files 72 72
Lines 1620 1620
=========================================
Hits 1521 1521
Misses 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
silasjoisten
requested changes
Jul 26, 2025
edodusi
requested changes
Jul 30, 2025
|
Yes and please add proper exception messages to all the other Asserts too. |
silasjoisten
requested changes
Aug 18, 2025
| if (null !== $values['path']) { | ||
| $path = TrimmedNonEmptyString::fromString($values['path'])->toString(); | ||
| if (null !== $values['path'] && '' !== $values['path']) { | ||
| $path = TrimmedNonEmptyString::fromString($values['path'], 'The value of key "path" is invalid.')->toString(); |
There was a problem hiding this comment.
@KristianH i am not so happy with this. Its too generic. Maybe something like The value of key "path" must be an trimmed non empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Note
I encountered a strange bug related to a Story in Storyblok. This PR might help identify the root cause.
Long Version
In the Storyblok API responses (both Management API and Content Delivery API), the
pathvalue was returned as an empty string ("") instead ofnull.Running the following command resulted in an error:Which produced:
As a result, many links were missing in the
LinkRegistry, which is part of thestoryblok/symfony-bundle.How to Fix This in Storyblok
Review the Content Delivery API response from Retrieve Multiple Links, for example:
Look for entries where
"path": ""(the expected default is"path": null).Delete and recreate the affected stories in the Storyblok editor.Final Note
I'm not sure whether this bug is easily reproducible in Storyblok — and I didn’t want to risk reproducing it in a production environment.
For context: the affected story had its
first_published_atvalue changed, and multi-language support was enabled.