Improving Test Coverage

Author: roberto-butti

src/ManagementApiClient.php

@@ -107,6 +107,7 @@ public function httpAssetClient(): HttpClientInterface
 
     /**
      * @deprecated Use `new StoryApi($managementApiClient, $spaceId, $logger)` instead.
+     * @codeCoverageIgnore
      */
     public function storyApi(
         string|int $spaceId,
@@ -122,6 +123,7 @@ public function storyApi(
 
     /**
      * @deprecated Use `new StoryBulkApi($managementApiClient, $spaceId, $logger)` instead.
+     * @codeCoverageIgnore
      */
     public function storyBulkApi(
         string|int $spaceId,
@@ -137,6 +139,7 @@ public function storyBulkApi(
 
     /**
      * @deprecated Use `new AssetApi($managementApiClient, $spaceId)` instead.
+     * @codeCoverageIgnore
      */
     public function assetApi(string|int $spaceId): AssetApi
     {
@@ -150,6 +153,7 @@ public function assetApi(string|int $spaceId): AssetApi
 
     /**
      * @deprecated Use `new TagApi($managementApiClient, $spaceId)` instead.
+     * @codeCoverageIgnore
      */
     public function tagApi(string|int $spaceId): TagApi
     {
@@ -163,6 +167,7 @@ public function tagApi(string|int $spaceId): TagApi
 
     /**
      * @deprecated Use `new WorkflowApi($managementApiClient, $spaceId)` instead.
+     * @codeCoverageIgnore
      */
     public function workflowApi(string|int $spaceId): WorkflowApi
     {
@@ -176,6 +181,7 @@ public function workflowApi(string|int $spaceId): WorkflowApi
 
     /**
      * @deprecated Use `new WorkflowStageApi($managementApiClient, $spaceId)` instead.
+     * @codeCoverageIgnore
      */
     public function workflowStageApi(string|int $spaceId): WorkflowStageApi
     {
@@ -189,6 +195,7 @@ public function workflowStageApi(string|int $spaceId): WorkflowStageApi
 
     /**
      * @deprecated Use `new ComponentApi($managementApiClient, $spaceId, $logger)` instead.
+     * @codeCoverageIgnore
      */
     public function componentApi(
         string|int $spaceId,
@@ -204,6 +211,7 @@ public function componentApi(
 
     /**
      * @deprecated Use `new ManagementApi($managementApiClient)` instead.
+     * @codeCoverageIgnore
      */
     public function managementApi(): ManagementApi
     {

tests/Feature/SpaceApiTest.php

@@ -55,8 +55,14 @@ public function testOneSpaceSpace(): void
         $this->assertSame("2018-11-10", $storyblokData->createdAt());
         $this->assertSame("2018-11-11", $storyblokData->updatedAt());
         $this->assertSame("Starter (Trial)", $storyblokData->planDescription());
-        $this->assertSame("https://example.storyblok.com", $storyblokData->domain());
-        $this->assertSame("8IE7MzYCzw5d7KLckDa38Att", $storyblokData->firstToken());
+        $this->assertSame(
+            "https://example.storyblok.com",
+            $storyblokData->domain(),
+        );
+        $this->assertSame(
+            "8IE7MzYCzw5d7KLckDa38Att",
+            $storyblokData->firstToken(),
+        );
         $this->assertFalse($storyblokData->isDemo());
         $this->assertSame(200, $storyblokResponse->getResponseStatusCode());
         $this->assertCount(0, $storyblokData->environments());
@@ -71,9 +77,7 @@ public function testOneSpaceSpace(): void
 
     public function testOneSpaceSetters(): void
     {
-        $responses = [
-            $this->mockResponse("one-space", 200),
-        ];
+        $responses = [$this->mockResponse("one-space", 200)];
 
         $client = new MockHttpClient($responses);
         $mapiClient = ManagementApiClient::initTest($client);
@@ -85,7 +89,10 @@ public function testOneSpaceSetters(): void
         $storyblokData->setName("New Name");
         $this->assertSame("New Name", $storyblokData->get("name"));
         $this->assertSame("2018-11-10", $storyblokData->createdAt());
-        $this->assertSame("https://example.storyblok.com", $storyblokData->get("domain"));
+        $this->assertSame(
+            "https://example.storyblok.com",
+            $storyblokData->get("domain"),
+        );
 
         $storyblokData->setDomain("example.com");
         $this->assertSame("New Name", $storyblokData->get("name"));
@@ -109,7 +116,10 @@ public function testCreatingOneSpaceSpace(): void
 
         $this->assertSame("New Name", $spaceData->get("name"));
         $this->assertSame("", $spaceData->createdAt());
-        $this->assertSame("https://example.storyblok.com", $spaceData->get("domain"));
+        $this->assertSame(
+            "https://example.storyblok.com",
+            $spaceData->get("domain"),
+        );
 
         $storyblokResponse = $spaceApi->create($spaceData);
         $storyblokData = $storyblokResponse->data();
@@ -182,6 +192,7 @@ public function testDeleteOneSpaceSpace(): void
     public function testDuplicatingOneSpaceSpace(): void
     {
         $responses = [
+            $this->mockResponse("one-space", 200),
             $this->mockResponse("one-space", 200),
             $this->mockResponse("empty-space", 404),
         ];
@@ -198,6 +209,20 @@ public function testDuplicatingOneSpaceSpace(): void
         $this->assertSame("2018-11-10", $storyblokData->createdAt());
         $this->assertSame("Starter (Trial)", $storyblokData->planDescription());
         $this->assertSame(200, $storyblokResponse->getResponseStatusCode());
+
+        $storyblokResponse = $spaceApi->duplicate(
+            "111",
+            "New Space Name",
+            inOrg: true,
+        );
+        $storyblokData = $storyblokResponse->data();
+
+        $this->assertSame("Example Space", $storyblokData->get("name"));
+
+        $this->assertSame("Example Space", $storyblokData->name());
+        $this->assertSame("2018-11-10", $storyblokData->createdAt());
+        $this->assertSame("Starter (Trial)", $storyblokData->planDescription());
+        $this->assertSame(200, $storyblokResponse->getResponseStatusCode());
     }
 
     public function testMultipleSpacesSpace(): void
@@ -224,4 +249,30 @@ public function testMultipleSpacesSpace(): void
 
         $this->assertSame(2, $storyblokData->howManySpaces());
     }
+
+    public function testUpdateSpace(): void
+    {
+        $responses = [$this->mockResponse("one-space", 200)];
+
+        $client = new MockHttpClient($responses);
+        $mapiClient = ManagementApiClient::initTest($client);
+        $spaceApi = new SpaceApi($mapiClient);
+
+        $spaceData = new Space("New Name");
+        $spaceData->setDomain("https://example.storyblok.com");
+
+        $storyblokResponse = $spaceApi->update("111", $spaceData);
+        $storyblokData = $storyblokResponse->data();
+
+        $this->assertSame("Example Space", $storyblokData->get("name"));
+        $this->assertSame("Example Space", $storyblokData->name());
+        $this->assertSame("2018-11-10", $storyblokData->createdAt());
+        $this->assertSame("Starter (Trial)", $storyblokData->planDescription());
+        $this->assertSame(200, $storyblokResponse->getResponseStatusCode());
+
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage("Space ID cannot be empty");
+        $spaceData = new Space("");
+        $spaceApi->update("", $spaceData);
+    }
 }