fix: add commercialRevShare conversion in setMaxLicenseTokens (#690)

fix: commercialRevShare in setMaxLicenseTokens

Author: bonnie57

packages/core-sdk/src/resources/license.ts

@@ -429,6 +429,7 @@ export class LicenseClient {
             expectMinimumGroupRewardShare: Math.trunc(
               licensingConfig.expectMinimumGroupRewardShare / 1000000,
             ),
+            commercialRevShare: Math.trunc(licensingConfig.commercialRevShare / 1000000),
           },
         });
       }

packages/core-sdk/test/integration/license.test.ts

@@ -221,7 +221,7 @@ describe("License Functions", () => {
         isSet: true,
         licensingHook: zeroAddress,
         hookData: randomHookData,
-        commercialRevShare: 0,
+        commercialRevShare: 100,
         disabled: false,
         expectMinimumGroupRewardShare: 1,
         expectGroupRewardPool: zeroAddress,
@@ -244,6 +244,7 @@ describe("License Functions", () => {
         expect(result).to.deep.equal({
           ...licensingConfig,
           expectMinimumGroupRewardShare: 1 * 10 ** 6,
+          commercialRevShare: 100 * 10 ** 6,
         });
       });
 

packages/core-sdk/test/unit/resources/license.test.ts

@@ -1288,7 +1288,7 @@ describe("Test LicenseClient", () => {
         mintingFee: 0n,
         licensingHook: zeroAddress,
         hookData: zeroAddress,
-        commercialRevShare: 0,
+        commercialRevShare: 10*10**6,
         disabled: false,
         expectMinimumGroupRewardShare: 1 * 10 ** 6,
         expectGroupRewardPool: zeroAddress,
@@ -1309,7 +1309,7 @@ describe("Test LicenseClient", () => {
         mintingFee: 0n,
         licensingHook: "0xaBAD364Bfa41230272b08f171E0Ca939bD600478",
         hookData: zeroAddress,
-        commercialRevShare: 0,
+        commercialRevShare: 10 * 10**6,
         disabled: false,
         expectMinimumGroupRewardShare: 1 * 10 ** 6,
         expectGroupRewardPool: zeroAddress,